Patch hb_set implementation back to pre 1.6.1 implementation again
Perf bisects indicate that the hb_set changes may be the reason for seing performance regressions in issues 781794 and 782220. The previous CL for patching the set implementation back [1] shows that this makes the performance graphs recover. In [2] we reduced the number of calls to HasSpaceInLigaturesOrKerning in an attempt to see whether this can address the performance regressions. However, the graphs in [3] show that even after Chromium revision 522394 (which is the revision for [3]) the graphs are not recovering. [1] https://chromium-review.googlesource.com/c/chromium/src/+/804374 [2] https://chromium-review.googlesource.com/c/chromium/src/+/809106 [3] https://chromeperf.appspot.com/group_report?bug_id=781794 Bug: 782220 Change-Id: Ib4708dbba70a36d1f7659ab00dfe8222e8623d8b Tbr: eae, kojii, behdad Reviewed-on: https://chromium-review.googlesource.com/816795Reviewed-by:Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#522757}
Showing
This diff is collapsed.
Please register or sign in to comment