Obsolete some SBDownloadFeedback metrics

Remove some SBDownloadFeedback metrics that weren't being used, and where
we don't have any near-term plans for them.

Bug: 984184, 984209
Change-Id: I35c5e77f20170ec4e8b8bba71b811f12c1d9899f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725161
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682371}

chrome/browser/safe_browsing/download_protection/download_feedback_service.cc

@@ -94,13 +94,9 @@ void DownloadFeedbackService::MaybeStorePingsForDownload(
     return;
   }
 
-  UMA_HISTOGRAM_BOOLEAN("SBDownloadFeedback.UploadRequestedByServer",
-                        upload_requested);
   if (!upload_requested)
     return;
 
-  UMA_HISTOGRAM_COUNTS_1M("SBDownloadFeedback.SizeEligibleKB",
-                          download->GetReceivedBytes() / 1024);
   if (download->GetReceivedBytes() > DownloadFeedback::kMaxUploadSize)
     return;
 
@@ -138,9 +134,6 @@ void DownloadFeedbackService::BeginFeedbackForDownload(
     download::DownloadItem* download,
     DownloadCommands::Command download_command) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
-  UMA_HISTOGRAM_ENUMERATION("SBDownloadFeedback.Activations",
-                            download->GetDangerType(),
-                            download::DOWNLOAD_DANGER_TYPE_MAX);
 
   DownloadFeedbackPings* pings = DownloadFeedbackPings::FromDownload(*download);
   DCHECK(pings);
@@ -164,10 +157,7 @@ void DownloadFeedbackService::BeginFeedbackOrDeleteFile(
     const std::string& ping_response,
     const base::FilePath& path) {
   if (service) {
-    bool is_path_empty = path.empty();
-    UMA_HISTOGRAM_BOOLEAN("SBDownloadFeedback.EmptyFilePathFailure",
-                          is_path_empty);
-    if (is_path_empty)
+    if (path.empty())
       return;
     service->BeginFeedback(ping_request, ping_response, path);
   } else {

tools/metrics/histograms/histograms.xml

@@ -117297,6 +117297,9 @@ Safe Browsing lookups, which is critical for security. -->
 
 <histogram name="SBDownloadFeedback.Activations" enum="DownloadItem.DangerType"
     expires_after="M78">
+  <obsolete>
+    Removed in M77, since the information was not being used.
+  </obsolete>
   <owner>vakh@chromium.org</owner>
   <owner>chrome-safebrowsing-alerts@google.com</owner>
   <owner>mattm@chromium.org</owner>
@@ -117329,6 +117332,9 @@ Safe Browsing lookups, which is critical for security. -->
 
 <histogram name="SBDownloadFeedback.EmptyFilePathFailure" enum="Boolean"
     expires_after="M78">
+  <obsolete>
+    Removed in M77, since the information was not being used.
+  </obsolete>
   <owner>vakh@chromium.org</owner>
   <owner>chrome-safebrowsing-alerts@google.com</owner>
   <summary>
@@ -117372,6 +117378,9 @@ Safe Browsing lookups, which is critical for security. -->
 
 <histogram name="SBDownloadFeedback.SizeEligibleKB" units="KB"
     expires_after="M78">
+  <obsolete>
+    Removed in M77, since the information was not being used.
+  </obsolete>
   <owner>vakh@chromium.org</owner>
   <owner>chrome-safebrowsing-alerts@google.com</owner>
   <owner>mattm@chromium.org</owner>
@@ -117413,6 +117422,9 @@ Safe Browsing lookups, which is critical for security. -->
 
 <histogram name="SBDownloadFeedback.UploadRequestedByServer"
     enum="DownloadUploadRequestedByServer" expires_after="M78">
+  <obsolete>
+    Removed in M77, since the information was not being used.
+  </obsolete>
   <owner>vakh@chromium.org</owner>
   <owner>chrome-safebrowsing-alerts@google.com</owner>
   <summary>