Log when the user opens a bookmark from the Mac top menu.

This is distinct from opening a bookmark from bookmarks bar, manager,
app/wrench menu, etc.

Bug: 951909
Change-Id: I8ba878a126d21696e74f821535929a59db3c120e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574424
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652683}

chrome/browser/bookmarks/bookmark_stats.cc

@@ -42,6 +42,8 @@ void RecordBookmarkLaunch(const BookmarkNode* node,
   } else if (location == BOOKMARK_LAUNCH_LOCATION_APP_MENU) {
     base::RecordAction(
         base::UserMetricsAction("WrenchMenu_Bookmarks_LaunchURL"));
+  } else if (location == BOOKMARK_LAUNCH_LOCATION_TOP_MENU) {
+    base::RecordAction(base::UserMetricsAction("TopMenu_Bookmarks_LaunchURL"));
   }
 
   UMA_HISTOGRAM_ENUMERATION("Bookmarks.LaunchLocation", location,

chrome/browser/bookmarks/bookmark_stats.h

@@ -37,6 +37,8 @@ enum BookmarkLaunchLocation {
   BOOKMARK_LAUNCH_LOCATION_MANAGER,
   // Autocomplete suggestion.
   BOOKMARK_LAUNCH_LOCATION_OMNIBOX,
+  // System application menu (e.g. on Mac).
+  BOOKMARK_LAUNCH_LOCATION_TOP_MENU,
 
   BOOKMARK_LAUNCH_LOCATION_LIMIT  // Keep this last.
 };

chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -9,6 +9,7 @@
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_BOOKMARK_MENU
 #import "chrome/browser/app_controller_mac.h"
+#include "chrome/browser/bookmarks/bookmark_stats.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
 #include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h"
@@ -102,6 +103,7 @@ NSMenuItem* GetItemWithSubmenu(NSMenu* submenu) {
       node->url(), Referrer(), disposition,
       ui::PAGE_TRANSITION_AUTO_BOOKMARK, false);
   browser->OpenURL(params);
+  RecordBookmarkLaunch(node, BOOKMARK_LAUNCH_LOCATION_TOP_MENU);
 }
 
 - (IBAction)openBookmarkMenuItem:(id)sender {

tools/metrics/actions/actions.xml

@@ -20798,6 +20798,15 @@ should be able to be added at any place in this file.
   <description>Please enter the description of this user action.</description>
 </action>
 
+<action name="TopMenu_Bookmarks_LaunchURL">
+  <owner>dfried@chromium.org</owner>
+  <description>
+    The user opened a bookmark from the application menu at the top of the
+    screen on, for example, MacOS. Distinguished from launching from the
+    wrench/app menu or the bookmarks bar.
+  </description>
+</action>
+
 <action name="Touchpad_Gesture_Overview">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>

tools/metrics/histograms/enums.xml

@@ -5109,6 +5109,7 @@ Unknown properties are collapsed to zero. -->
   <int value="4" label="Wrench menu"/>
   <int value="5" label="Bookmark manager"/>
   <int value="6" label="Omnibox suggestion"/>
+  <int value="7" label="Top application menu (Mac, etc.)"/>
 </enum>
 
 <enum name="BookmarkManagerCommand">