[android] Proguard out most of guava

This CL removes most of guava, except a few classes and annotations.

Also updates the rest of Chrome to ensure only those classes are in use.

Thirdly, it adds an OWNERS file to third_party/guava.

BUG=163393
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/546973003

Cr-Commit-Position: refs/heads/master@{#293828}

chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java

@@ -7,8 +7,6 @@ package org.chromium.chrome.browser.sync;
 import android.content.Context;
 import android.util.Log;
 
-import com.google.common.base.Joiner;
-
 import org.chromium.base.CalledByNative;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
@@ -17,6 +15,7 @@ import org.chromium.sync.internal_api.pub.SyncDecryptionPassphraseType;
 import org.chromium.sync.internal_api.pub.base.ModelType;
 
 import java.util.HashSet;
+import java.util.Iterator;
 import java.util.List;
 import java.util.Set;
 import java.util.SortedSet;
@@ -533,7 +532,16 @@ public class ProfileSyncService {
         for (ModelType type : filteredTypes) {
             set.add(type.toString());
         }
-        return Joiner.on(", ").join(set);
+        StringBuilder sb = new StringBuilder();
+        Iterator<String> it = set.iterator();
+        if (it.hasNext()) {
+            sb.append(it.next());
+            while (it.hasNext()) {
+                sb.append(", ");
+                sb.append(it.next());
+            }
+        }
+        return sb.toString();
     }
 
     // Native methods

chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java

@@ -26,7 +26,6 @@ import android.widget.LinearLayout;
 import android.widget.TextView;
 
 import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Strings;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.EmptyTabObserver;
@@ -264,7 +263,7 @@ public class AccessibilityTabModelListItem extends FrameLayout implements OnClic
 
     private void updateTabTitle() {
         String title = mTab != null ? mTab.getTitle() : null;
-        if (Strings.isNullOrEmpty(title)) {
+        if (title == null || title.isEmpty()) {
             title = getContext().getResources().getString(R.string.tab_loading_default_title);
         }
 

third_party/guava/OWNERS

+nyquist@chromium.org
+yfriedman@chromium.org

third_party/guava/proguard.flags

@@ -2,12 +2,12 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
--keep class com.google.common.base.** {
-  *;
-}
-
--keep class com.google.common.annotations.** {
-  *;
+-keep class com.google.common.annotations.VisibleForTesting,
+            com.google.common.base.Preconditions,
+            com.google.common.base.Objects,
+            com.google.common.base.Strings,
+            com.google.common.base.Supplier {
+    *;
 }
 
 -keepattributes Signature