Commit b0a8319c authored by Eric Seckler's avatar Eric Seckler Committed by Commit Bot

perfetto: Increase startup writer buffer size.

Telemetry perf tests are flaky because some startup tracing data
is lost. Increase the buffer size until we have a better way to deal
with this.

Change-Id: I6341c71147472079cb5f075e4cefefe2042e55f7
Bug: 914092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847221Reviewed-by: default avatarJuan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703775}
parent 969de911
...@@ -392,6 +392,11 @@ base::ThreadLocalStorage::Slot* ThreadLocalEventSinkSlot() { ...@@ -392,6 +392,11 @@ base::ThreadLocalStorage::Slot* ThreadLocalEventSinkSlot() {
TraceEventDataSource* g_trace_event_data_source_for_testing = nullptr; TraceEventDataSource* g_trace_event_data_source_for_testing = nullptr;
// crbug.com/914092: This has to be large enough for DevTools to be able to
// start up and telemetry to start tracing through it before the buffer is
// exhausted.
constexpr size_t kMaxStartupWriterBufferSize = 10 * 1024 * 1024;
} // namespace } // namespace
// static // static
...@@ -759,7 +764,7 @@ TraceEventDataSource::CreateTraceWriterLocked() { ...@@ -759,7 +764,7 @@ TraceEventDataSource::CreateTraceWriterLocked() {
// service. // service.
auto buffer_exhausted_policy = perfetto::BufferExhaustedPolicy::kDrop; auto buffer_exhausted_policy = perfetto::BufferExhaustedPolicy::kDrop;
trace_writer = startup_writer_registry_->CreateUnboundTraceWriter( trace_writer = startup_writer_registry_->CreateUnboundTraceWriter(
buffer_exhausted_policy); buffer_exhausted_policy, kMaxStartupWriterBufferSize);
} else if (producer_) { } else if (producer_) {
trace_writer = std::make_unique<perfetto::StartupTraceWriter>( trace_writer = std::make_unique<perfetto::StartupTraceWriter>(
producer_->CreateTraceWriter(target_buffer_)); producer_->CreateTraceWriter(target_buffer_));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment