Fix MaybeFinishConnectorRequest for auth request

The "if" removed in MaybeFinishConnectorRequest would prevent the auth
request from completing since received_connector_responses_ is populated
by tags in OnGetConnectorResponse. Since the auth request doesn't use
tags, that map entry would stay empty and the request would be blocked
from finishing.

This CL also removes MaybeFinishRequest since it has no caller.

Change-Id: Iae87f675bb8fb1690c34d3fececf1698a7e391e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261165Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781548}

chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc

@@ -359,17 +359,7 @@ void BinaryUploadService::OnGetLegacyResponse(
   MaybeFinishLegacyRequest(request);
 }
 
-void BinaryUploadService::MaybeFinishRequest(Request* request) {
-  if (request->use_legacy_proto())
-    MaybeFinishLegacyRequest(request);
-  else
-    MaybeFinishConnectorRequest(request);
-}
-
 void BinaryUploadService::MaybeFinishConnectorRequest(Request* request) {
-  if (!received_connector_responses_.contains(request))
-    return;
-
   for (const std::string& tag : request->content_analysis_request().tags()) {
     const auto& results = received_connector_responses_[request].results();
     if (std::none_of(

chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.h

@@ -255,7 +255,6 @@ class BinaryUploadService : public KeyedService {
   void OnGetLegacyResponse(Request* request,
                            DeepScanningClientResponse response);
 
-  void MaybeFinishRequest(Request* request);
   void MaybeFinishConnectorRequest(Request* request);
   void MaybeFinishLegacyRequest(Request* request);