Commit b126d916 authored by sebmarchand's avatar sebmarchand Committed by Commit bot

Force mini_installer to be optimized for size for the official builds.

It doesn't change anything to the current official build configuration ! 'size' is already the default value for the 'optimize' variable (https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=5411), but we override this value when doing a PGO build, so this is just preventing the mini_installer from being PGO optimized.

BUG=309849

Review URL: https://codereview.chromium.org/1037793004

Cr-Commit-Position: refs/heads/master@{#322198}
parent c0fdb3e0
...@@ -223,15 +223,15 @@ ...@@ -223,15 +223,15 @@
'message': 'Create installer archive', 'message': 'Create installer archive',
}, },
], ],
# TODO(mark): <(branding_dir) should be defined by the
# global condition block at the bottom of the file, but
# this doesn't work due to the following issue:
#
# http://code.google.com/p/gyp/issues/detail?id=22
#
# Remove this block once the above issue is fixed.
'conditions': [ 'conditions': [
[ 'branding == "Chrome"', { # TODO(mark): <(branding_dir) should be defined by the
# global condition block at the bottom of the file, but
# this doesn't work due to the following issue:
#
# http://code.google.com/p/gyp/issues/detail?id=22
#
# Remove this block once the above issue is fixed.
['branding == "Chrome"', {
'variables': { 'variables': {
'branding_dir': '../app/theme/google_chrome', 'branding_dir': '../app/theme/google_chrome',
}, },
...@@ -240,5 +240,9 @@ ...@@ -240,5 +240,9 @@
'branding_dir': '../app/theme/chromium', 'branding_dir': '../app/theme/chromium',
}, },
}], }],
['OS=="win" and buildtype=="Official"', {
# Optimize for size when doing an official build.
'optimize' :'size',
}],
], ],
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment