Commit b148888f authored by isherman@chromium.org's avatar isherman@chromium.org

Match FormStructure DCHECK to AutoFillManager's check in OnFormSubmitted()

BUG=70883
TEST=none

Review URL: http://codereview.chromium.org/6273015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72671 0039d316-1c4b-4281-b951-d872f2087c98
parent 9d063448
...@@ -108,7 +108,7 @@ bool FormStructure::EncodeUploadRequest(bool auto_fill_used, ...@@ -108,7 +108,7 @@ bool FormStructure::EncodeUploadRequest(bool auto_fill_used,
std::string* encoded_xml) const { std::string* encoded_xml) const {
DCHECK(encoded_xml); DCHECK(encoded_xml);
encoded_xml->clear(); encoded_xml->clear();
bool auto_fillable = IsAutoFillable(false); bool auto_fillable = ShouldBeParsed(true);
DCHECK(auto_fillable); // Caller should've checked for search pages. DCHECK(auto_fillable); // Caller should've checked for search pages.
if (!auto_fillable) if (!auto_fillable)
return false; return false;
......
...@@ -144,9 +144,15 @@ TEST_F(SessionHistoryTest, MAYBE_BasicBackForward) { ...@@ -144,9 +144,15 @@ TEST_F(SessionHistoryTest, MAYBE_BasicBackForward) {
EXPECT_EQ(L"bot3", GetTabTitle()); EXPECT_EQ(L"bot3", GetTabTitle());
} }
#if defined(OS_WIN)
// See http://crbug.com/61619
#define MAYBE_FrameBackForward FLAKY_FrameBackForward
#else
#define MAYBE_FrameBackForward FrameBackForward
#endif
// Test that back/forward works when navigating in subframes. // Test that back/forward works when navigating in subframes.
// Flaky, http://crbug.com/61619 and http://crbug.com/70883. TEST_F(SessionHistoryTest, MAYBE_FrameBackForward) {
TEST_F(SessionHistoryTest, FLAKY_FrameBackForward) {
ASSERT_TRUE(test_server_.Start()); ASSERT_TRUE(test_server_.Start());
// about:blank should be loaded first. // about:blank should be loaded first.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment