Commit b177e8b5 authored by Carlos Knippschild's avatar Carlos Knippschild Committed by Commit Bot

Enable by default opening offline pages in CCTs from the DH

Bug: 824807
Change-Id: Iaec899173324ad82ce702406077f3664b7db8e57
Reviewed-on: https://chromium-review.googlesource.com/1117746Reviewed-by: default avatarDmitry Titov <dimich@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570985}
parent 1c593052
......@@ -68,7 +68,7 @@ const base::Feature kOfflinePagesDescriptivePendingStatusFeature{
"OfflinePagesDescriptivePendingStatus", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kOfflinePagesInDownloadHomeOpenInCctFeature{
"OfflinePagesInDownloadHomeOpenInCct", base::FEATURE_DISABLED_BY_DEFAULT};
"OfflinePagesInDownloadHomeOpenInCct", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kOfflinePagesCTSuppressNotificationsFeature{
"OfflinePagesCTSuppressNotifications", base::FEATURE_DISABLED_BY_DEFAULT};
......
......@@ -114,14 +114,14 @@ TEST(OfflinePageFeatureTest, OfflinePagesLimitlessPrefetching) {
}
TEST(OfflinePageFeatureTest, OfflinePagesInDownloadHomeOpenInCct) {
// Disabled by default.
EXPECT_FALSE(offline_pages::ShouldOfflinePagesInDownloadHomeOpenInCct());
// Enabled by default.
EXPECT_TRUE(offline_pages::ShouldOfflinePagesInDownloadHomeOpenInCct());
// Check if helper method works correctly when the features is enabled.
// Check if helper method works correctly when the features is disabled.
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(
scoped_feature_list.InitAndDisableFeature(
kOfflinePagesInDownloadHomeOpenInCctFeature);
EXPECT_TRUE(offline_pages::ShouldOfflinePagesInDownloadHomeOpenInCct());
EXPECT_FALSE(offline_pages::ShouldOfflinePagesInDownloadHomeOpenInCct());
}
TEST(OfflinePageFeatureTest, OfflinePagesDescriptiveFailStatus) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment