Commit b18c8e7c authored by Bailey Berro's avatar Bailey Berro Committed by Commit Bot

Switch to ReportUnrecoverableError in PrintersSyncBridge

This change switches to calling sync's ReportUnrecoverableError
function rather that DumpWithoutCrash. This reduces the number of crash
reports that are uploaded with this signature.

Change-Id: I46cf634bbfa4dcd460dae89dd4b91a412678fa7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862246
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706947}
parent ddb9567a
......@@ -8,13 +8,14 @@
#include <utility>
#include "base/bind.h"
#include "base/debug/dump_without_crashing.h"
#include "chrome/browser/chromeos/printing/printers_sync_bridge.h"
#include "chrome/browser/chromeos/printing/synced_printers_manager.h"
#include "chrome/browser/profiles/incognito_helpers.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/model_type_store_service_factory.h"
#include "chrome/common/channel_info.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/sync/base/report_unrecoverable_error.h"
#include "components/sync/model/model_type_store_service.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
......@@ -63,8 +64,9 @@ SyncedPrintersManager* SyncedPrintersManagerFactory::BuildServiceInstanceFor(
std::unique_ptr<PrintersSyncBridge> sync_bridge =
std::make_unique<PrintersSyncBridge>(
std::move(store_factory), base::BindRepeating(base::IgnoreResult(
&base::debug::DumpWithoutCrashing)));
std::move(store_factory),
base::BindRepeating(&syncer::ReportUnrecoverableError,
chrome::GetChannel()));
return SyncedPrintersManager::Create(profile, std::move(sync_bridge))
.release();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment