Commit b1969b94 authored by simonb's avatar simonb Committed by Commit bot

Skip direct map from apk check for all Samsung.

If the device manufacturer is Samsung, skip the check for mmap
exec support.  This avoids triggering a warning on some devices.

See also:
  https://codereview.chromium.org/869593002/
  https://codereview.chromium.org/858983002/
  https://codereview.chromium.org/857833002/

BUG=448084

Review URL: https://codereview.chromium.org/900553005

Cr-Commit-Position: refs/heads/master@{#314362}
parent 7808da74
......@@ -175,18 +175,12 @@ public class LibraryLoader {
String apkFilePath = null;
boolean useMapExecSupportFallback = false;
// If the Android build version pre-dates KitKat and the device
// manufacturer is Samsung, skip the check for mmap exec support and
// return false. This avoids triggering a warning on these devices.
// The version check is included because these devices do not show
// the warning on later OS builds.
// If manufacturer is Samsung then skip the mmap exec check.
//
// For more, see:
// https://code.google.com/p/chromium/issues/detail?id=448084
final String manufacturer = android.os.Build.MANUFACTURER;
final int version = android.os.Build.VERSION.SDK_INT;
if (manufacturer != null
&& version < android.os.Build.VERSION_CODES.KITKAT
&& manufacturer.toLowerCase(Locale.ENGLISH).contains("samsung")) {
Log.w(TAG, "Suppressed load from APK support check on this device");
sProbeMapApkWithExecPermission = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment