Initialize FrameResourceFetcherProperties::web_bundle_physical_url_ in ctor
When HtmlImportsRequestInitiatorLock is disabled, FrameLoader::document_loader_ is cleared by FrameLoader::DetachDocument() before FrameLoader::DetachDocument() calls Document::Shutdown() -> HTMLImportsController::Dispose() -> HTMLImportLoader::Dispose() -> Document::ClearImportsController() -> ResourceFetcher::ClearContext() -> DetachableResourceFetcherProperties::Detach() -> FrameResourceFetcherProperties::WebBundlePhysicalUrl() -> FrameOrImportedDocument::GetMasterDocumentLoader() -> FrameLoader::GetDocumentLoader() So frame_or_imported_document_->GetMasterDocumentLoader() returns invalid reference of DocumentLoader. This is causing crashes from Dec 20 when HtmlImportsRequestInitiatorLock was disabled in M80 using Field Trial Testing Configuration. To avoid this crash, this cl change FrameResourceFetcherProperties not to call ResourceFetcherProperties::WebBundlePhysicalUrl() from DetachableResourceFetcherProperties::Detach(). Bug: 1036049 Change-Id: If6a947ebec0dbbea0e39d5eb979eed8c8d39f018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978340Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728756}
Showing
Please register or sign in to comment