Fix Linux panels to return to fully minimized mode after mouse moves away.

Regression came from change to leave panel in title-only mode
when draw attention is cleared, but mouse is over the panel title. (r137530)

BUG=None
TEST=Updated StopDrawingAttentionWhileMinimized and DragMinimizedPanelWhileDrawingAttention


Review URL: https://chromiumcodereview.appspot.com/10828220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151190 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/ui/panels/docked_panel_strip.cc

@@ -585,6 +585,9 @@ bool DockedPanelStrip::ShouldBringUpTitlebars(int mouse_x, int mouse_y) const {
 }
 
 void DockedPanelStrip::BringUpOrDownTitlebars(bool bring_up) {
+  if (are_titlebars_up_ == bring_up)
+    return;
+
   are_titlebars_up_ = bring_up;
   int task_delay_ms = 0;
 

chrome/browser/ui/panels/old_panel_browsertest.cc

@@ -1043,7 +1043,14 @@ IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest,
   EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
   EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());
 
-  // Move mouse away and panel should go back to fully minimized state.
+  // Typical user scenario will detect the mouse in the panel
+  // after attention is cleared, causing titles to pop up, so
+  // we simulate that here.
+  MoveMouseAndWaitForExpansionStateChange(panel2, hover_point_in_panel);
+  EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
+  EXPECT_EQ(Panel::TITLE_ONLY, panel2->expansion_state());
+
+  // Move mouse away and panels should go back to fully minimized state.
   MoveMouseAndWaitForExpansionStateChange(panel1, hover_point);
   EXPECT_EQ(Panel::MINIMIZED, panel1->expansion_state());
   EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());

chrome/browser/ui/panels/old_panel_drag_browsertest.cc

@@ -471,6 +471,11 @@ IN_PROC_BROWSER_TEST_F(OldPanelDragBrowserTest,
   EXPECT_FALSE(panel->IsDrawingAttention());
   EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
 
+  // Typical user scenario will detect the mouse in the panel
+  // after attention is cleared, causing titles to pop up, so
+  // we simulate that here.
+  MoveMouse(mouse_location);
+
   // Verify panel returns to fully minimized state after dragging ends once
   // mouse moves away from the panel.
   panel_testing->FinishDragTitlebar();

chrome/browser/ui/panels/panel_browsertest.cc

@@ -1132,7 +1132,14 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, StopDrawingAttentionWhileMinimized) {
   EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
   EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());
 
-  // Move mouse away and panel should go back to fully minimized state.
+  // Typical user scenario will detect the mouse in the panel
+  // after attention is cleared, causing titles to pop up, so
+  // we simulate that here.
+  MoveMouseAndWaitForExpansionStateChange(panel2, hover_point_in_panel);
+  EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
+  EXPECT_EQ(Panel::TITLE_ONLY, panel2->expansion_state());
+
+  // Move mouse away and panels should go back to fully minimized state.
   MoveMouseAndWaitForExpansionStateChange(panel1, hover_point);
   EXPECT_EQ(Panel::MINIMIZED, panel1->expansion_state());
   EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());

chrome/browser/ui/panels/panel_drag_browsertest.cc

@@ -474,6 +474,11 @@ IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest,
   EXPECT_FALSE(panel->IsDrawingAttention());
   EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
 
+  // Typical user scenario will detect the mouse in the panel
+  // after attention is cleared, causing titles to pop up, so
+  // we simulate that here.
+  MoveMouse(mouse_location);
+
   // Verify panel returns to fully minimized state after dragging ends once
   // mouse moves away from the panel.
   panel_testing->FinishDragTitlebar();