Commit b1d77cf0 authored by Henrique Nakashima's avatar Henrique Nakashima Committed by Commit Bot

Modularize DeviceClassManager to chrome/browser/device

The device module is a "higher level flags" target, which dictates if
broader features should be turned on or off based on the device,
command line, and some feature flags.

Change-Id: I9842eb8236966af5308bcc29c0ca0ccd1315d812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382670Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809576}
parent 7ed6f397
......@@ -306,6 +306,7 @@ android_library("chrome_java") {
"//chrome/browser/android/lifecycle:java",
"//chrome/browser/browser_controls/android:java",
"//chrome/browser/contextmenu:java",
"//chrome/browser/device:java",
"//chrome/browser/download/android:factory_java",
"//chrome/browser/download/android:java",
"//chrome/browser/download/android:java_resources",
......@@ -788,6 +789,7 @@ junit_binary("chrome_junit_tests") {
"//chrome/browser/android/lifecycle:java",
"//chrome/browser/browser_controls/android:java",
"//chrome/browser/browser_controls/android:junit",
"//chrome/browser/device:java",
"//chrome/browser/download/android:java",
"//chrome/browser/download/android:junit_tests",
"//chrome/browser/endpoint_fetcher:java",
......@@ -984,6 +986,7 @@ android_library("chrome_test_java") {
"//chrome/browser/android/lifecycle:java",
"//chrome/browser/browser_controls/android:java",
"//chrome/browser/contextmenu:java",
"//chrome/browser/device:java",
"//chrome/browser/download/android:java",
"//chrome/browser/engagement/android:java",
"//chrome/browser/enterprise/util:java",
......
......@@ -490,7 +490,6 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/dependency_injection/ChromeAppModule.java",
"java/src/org/chromium/chrome/browser/dependency_injection/ChromeCommonQualifiers.java",
"java/src/org/chromium/chrome/browser/dependency_injection/ModuleFactoryOverrides.java",
"java/src/org/chromium/chrome/browser/device/DeviceClassManager.java",
"java/src/org/chromium/chrome/browser/device_dialog/BluetoothChooserDialog.java",
"java/src/org/chromium/chrome/browser/device_dialog/BluetoothScanningPermissionDialog.java",
"java/src/org/chromium/chrome/browser/device_dialog/DeviceItemAdapter.java",
......
# Copyright 2020 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//build/config/android/rules.gni")
android_library("java") {
sources = [ "android/java/src/org/chromium/chrome/browser/device/DeviceClassManager.java" ]
deps = [
"//base:base_java",
"//chrome/browser/flags:java",
"//chrome/browser/preferences:java",
"//chrome/browser/util:java",
"//third_party/android_deps:androidx_annotation_annotation_java",
"//ui/android:ui_no_recycler_view_java",
]
}
file://chrome/android/OWNERS
# COMPONENT: Internals>Flags
# TEAM: chrome-android-app@chromium.org
# OS: Android
......@@ -66,10 +66,9 @@ public class DeviceClassManager {
// Flag based configurations.
CommandLine commandLine = CommandLine.getInstance();
mEnableAccessibilityLayout |= commandLine
.hasSwitch(ChromeSwitches.ENABLE_ACCESSIBILITY_TAB_SWITCHER);
mEnableFullscreen =
!commandLine.hasSwitch(ChromeSwitches.DISABLE_FULLSCREEN);
mEnableAccessibilityLayout |=
commandLine.hasSwitch(ChromeSwitches.ENABLE_ACCESSIBILITY_TAB_SWITCHER);
mEnableFullscreen = !commandLine.hasSwitch(ChromeSwitches.DISABLE_FULLSCREEN);
// Related features.
if (mEnableAccessibilityLayout) {
......@@ -88,6 +87,7 @@ public class DeviceClassManager {
* @return Whether or not should use the accessibility tab switcher.
*/
public static boolean enableAccessibilityLayout() {
// TODO(crbug.com/1007598): Support TabGrid and TabGroup in Accessibility mode.
if (isPhone()
&& CachedFeatureFlags.isEnabled(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
&& CachedFeatureFlags.isEnabled(ChromeFeatureList.TAB_GROUPS_ANDROID)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment