Commit b1e2f5ec authored by sunnyps's avatar sunnyps Committed by Commit bot

cc: Fix incorrect deadline for MISSED BeginFrames.

EstimatedParentDrawTime was not being subtracted from MISSED BeginFrames
as it is for all other BeginFrames.

Review URL: https://codereview.chromium.org/1025373002

Cr-Commit-Position: refs/heads/master@{#321918}
parent 8e57e5ba
...@@ -390,19 +390,19 @@ bool Scheduler::OnBeginFrameMixInDelegate(const BeginFrameArgs& args) { ...@@ -390,19 +390,19 @@ bool Scheduler::OnBeginFrameMixInDelegate(const BeginFrameArgs& args) {
client_->SendBeginFramesToChildren(adjusted_args_for_children); client_->SendBeginFramesToChildren(adjusted_args_for_children);
} }
BeginFrameArgs adjusted_args(args);
adjusted_args.deadline -= EstimatedParentDrawTime();
// We have just called SetNeedsBeginFrame(true) and the BeginFrameSource has // We have just called SetNeedsBeginFrame(true) and the BeginFrameSource has
// sent us the last BeginFrame we have missed. As we might not be able to // sent us the last BeginFrame we have missed. As we might not be able to
// actually make rendering for this call, handle it like a "retro frame". // actually make rendering for this call, handle it like a "retro frame".
// TODO(brainderson): Add a test for this functionality ASAP! // TODO(brainderson): Add a test for this functionality ASAP!
if (args.type == BeginFrameArgs::MISSED) { if (adjusted_args.type == BeginFrameArgs::MISSED) {
begin_retro_frame_args_.push_back(args); begin_retro_frame_args_.push_back(adjusted_args);
PostBeginRetroFrameIfNeeded(); PostBeginRetroFrameIfNeeded();
return true; return true;
} }
BeginFrameArgs adjusted_args(args);
adjusted_args.deadline -= EstimatedParentDrawTime();
bool should_defer_begin_frame; bool should_defer_begin_frame;
if (settings_.using_synchronous_renderer_compositor) { if (settings_.using_synchronous_renderer_compositor) {
should_defer_begin_frame = false; should_defer_begin_frame = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment