customtabs: Remove feature for parallel request, as it's launched.

We don't need the feature anymore, especially since this will be available
before native is loaded. In this case the feature flag would be at best
misleading (because its setting would not be respected), and at worst cause
crashes (calling a native method before native is loaded).

Bug: 901835
Change-Id: I5e07931674ac1344e3ff3eff805c6b9d15e159d0
Reviewed-on: https://chromium-review.googlesource.com/c/1341833Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610161}

chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java

@@ -168,7 +168,6 @@ public abstract class ChromeFeatureList {
     public static final String CCT_MODULE_CUSTOM_HEADER = "CCTModuleCustomHeader";
     public static final String CCT_MODULE_POST_MESSAGE = "CCTModulePostMessage";
     public static final String CCT_EXTERNAL_LINK_HANDLING = "CCTExternalLinkHandling";
-    public static final String CCT_PARALLEL_REQUEST = "CCTParallelRequest";
     public static final String CCT_POST_MESSAGE_API = "CCTPostMessageAPI";
     public static final String CCT_REDIRECT_PRECONNECT = "CCTRedirectPreconnect";
     public static final String CCT_RESOURCE_PREFETCH = "CCTResourcePrefetch";

chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

@@ -1002,13 +1002,11 @@ public class CustomTabsConnection {
         ThreadUtils.assertOnUiThread();
         // The restrictions are:
         // - Native initialization: Required to get the profile, and the feature state.
-        // - Feature check
         // - The referrer's origin is allowed.
         //
         // TODO(lizeb): Relax the restrictions.
         return ChromeBrowserInitializer.getInstance(ContextUtils.getApplicationContext())
                        .hasNativeInitializationCompleted()
-                && ChromeFeatureList.isEnabled(ChromeFeatureList.CCT_PARALLEL_REQUEST)
                 && mClientManager.isFirstPartyOriginForSession(session, new Origin(referrer));
     }
 

chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

@@ -2392,7 +2392,6 @@ public class CustomTabActivityTest {
 
     @Test
     @SmallTest
-    @EnableFeatures(ChromeFeatureList.CCT_PARALLEL_REQUEST)
     public void testParallelRequest() throws Exception {
         String url = mTestServer.getURL("/echoheader?Cookie");
         Uri requestUri = Uri.parse(mTestServer.getURL("/set-cookie?acookie"));

chrome/browser/android/chrome_feature_list.cc

@@ -88,7 +88,6 @@ const base::Feature* kFeaturesExposedToJava[] = {
     &kCCTModuleCache,
     &kCCTModuleCustomHeader,
     &kCCTModulePostMessage,
-    &kCCTParallelRequest,
     &kCCTPostMessageAPI,
     &kCCTRedirectPreconnect,
     &kCCTReportParallelRequestStatus,
@@ -237,9 +236,6 @@ const base::Feature kCCTModuleCustomHeader{"CCTModuleCustomHeader",
 const base::Feature kCCTModulePostMessage{"CCTModulePostMessage",
                                           base::FEATURE_DISABLED_BY_DEFAULT};
 
-const base::Feature kCCTParallelRequest{"CCTParallelRequest",
-                                        base::FEATURE_ENABLED_BY_DEFAULT};
-
 const base::Feature kCCTPostMessageAPI{"CCTPostMessageAPI",
                                        base::FEATURE_ENABLED_BY_DEFAULT};
 

chrome/browser/android/chrome_feature_list.h

@@ -27,7 +27,6 @@ extern const base::Feature kCCTModule;
 extern const base::Feature kCCTModuleCache;
 extern const base::Feature kCCTModuleCustomHeader;
 extern const base::Feature kCCTModulePostMessage;
-extern const base::Feature kCCTParallelRequest;
 extern const base::Feature kCCTPostMessageAPI;
 extern const base::Feature kCCTRedirectPreconnect;
 extern const base::Feature kCCTReportParallelRequestStatus;