Commit b21efacc authored by Mei Liang's avatar Mei Liang Committed by Commit Bot

[CloseSuggestion] Add strings

This CL adds strings for closing suggestion, and suppresses the un-used
resources error util the strings are being used in code.

Change-Id: I636a6262064c6f0938955ac651de9d8a3272b38b
Bug: 1004570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902441Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714626}
parent 77c8de16
...@@ -332,6 +332,10 @@ Still reading? ...@@ -332,6 +332,10 @@ Still reading?
<issue id="UniqueConstants" severity="ignore"/> <issue id="UniqueConstants" severity="ignore"/>
<issue id="UnusedResources"> <issue id="UnusedResources">
<!-- Do not add new suppressions without rationale. --> <!-- Do not add new suppressions without rationale. -->
<!-- crbug.com/1004570 remove this line and the following three lines after the bug resolved -->
<ignore regexp="The resource `R.string.tab_suggestion_review_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_tab_action_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_stale_message` appears to be unused"/>
<!-- 3 raw resources are accessed by URL in various places --> <!-- 3 raw resources are accessed by URL in various places -->
<ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits.html"/> <ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits.html"/>
<ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits_css.css"/> <ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits_css.css"/>
......
...@@ -196,6 +196,17 @@ ...@@ -196,6 +196,17 @@
<message name="IDS_ACCESSIBILITY_TAB_SWITCHER_CAROUSEL_MORE_TABS" desc="Accessibility message of the more Tabs button on the single pane start surface."> <message name="IDS_ACCESSIBILITY_TAB_SWITCHER_CAROUSEL_MORE_TABS" desc="Accessibility message of the more Tabs button on the single pane start surface.">
More tabs More tabs
</message> </message>
<!-- Tab Suggestion strings -->
<message name="IDS_TAB_SUGGESTION_REVIEW_BUTTON" desc="This text button shows on the TabSuggestion card. When user clicks this text button, user will enter a selection mode where they can view all the suggested tabs and the rest of the open tabs.">
Review
</message>
<message name="IDS_TAB_SUGGESTION_CLOSE_TAB_ACTION_BUTTON" desc="This text button shows on the toolbar of the selection mode. When user clicks this text button, all the selected tabs will be closed">
Close
</message>
<message name="IDS_TAB_SUGGESTION_CLOSE_STALE_MESSAGE" desc="This text shows on the TabSuggestion card. It describes the TabSuggestion.">
<ph name="NUMBER_OF_TABS">%1$s<ex>2</ex></ph> of your tabs haven't been used lately. Close them?
</message>
</messages> </messages>
</release> </release>
</grit> </grit>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment