CrIconButton: No ripple on focus capability

Bug: 1128599
Change-Id: I821f2adb8b13cdbd8d161a6b7cd75dc667cd7be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450813
Commit-Queue: Roman Arora <romanarora@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815419}

chrome/test/data/webui/cr_elements/cr_icon_button_focus_tests.js

@@ -67,4 +67,15 @@ suite('cr-icon-button-focus-tests', function() {
     button.dispatchEvent(new PointerEvent('pointerdown'));
     assertTrue(button.hasRipple());
   });
+
+  test('when no-ripple-on-focus, no ripple on focus', () => {
+    button.noRippleOnFocus = false;
+    button.focus();
+    assertTrue(button.getRipple().holdDown);
+
+    button.blur();
+    button.noRippleOnFocus = true;
+    button.focus();
+    assertFalse(button.getRipple().holdDown);
+  });
 });

ui/webui/resources/cr_elements/cr_icon_button/cr_icon_button.js

@@ -69,6 +69,11 @@ Polymer({
       reflectToAttribute: true,
     },
 
+    noRippleOnFocus: {
+      type: Boolean,
+      value: false,
+    },
+
     /** @private */
     multipleIcons_: {
       type: Boolean,
@@ -93,7 +98,7 @@ Polymer({
     blur: 'onBlur_',
     click: 'onClick_',
     down: 'showRipple_',
-    focus: 'showRipple_',
+    focus: 'onFocus_',
     keydown: 'onKeyDown_',
     keyup: 'onKeyUp_',
     pointerdown: 'ensureRipple',
@@ -155,10 +160,20 @@ Polymer({
     this.setAttribute('tabindex', value);
   },
 
+  /** @private */
+  onFocus_() {
+    if (!this.noRippleOnFocus) {
+      this.showRipple_();
+    }
+  },
+
   /** @private */
   onBlur_() {
     this.spaceKeyDown_ = false;
-    this.hideRipple_();
+
+    if (!this.noRippleOnFocus) {
+      this.hideRipple_();
+    }
   },
 
   /**