Commit b258e1aa authored by Kyle Horimoto's avatar Kyle Horimoto Committed by Commit Bot

[CrOS Cellular] Fix two issues with FakeOtaActivator.

(1) Make the destructor virtual and override base class destructors.
(2) Remove extraneous #endif from the .cc file.

These issues were caught by vkuzkokov@ on
https://chromium-review.googlesource.com/c/chromium/src/+/1604213

Change-Id: I1f82c04139c57880a46acfe904a528853f589fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628938
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: default avatarVladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663154}
parent 6eb7fb4e
...@@ -18,5 +18,3 @@ FakeOtaActivator::~FakeOtaActivator() = default; ...@@ -18,5 +18,3 @@ FakeOtaActivator::~FakeOtaActivator() = default;
} // namespace cellular_setup } // namespace cellular_setup
} // namespace chromeos } // namespace chromeos
#endif // CHROMEOS_SERVICES_CELLULAR_SETUP_FAKE_OTA_ACTIVATOR_H_
...@@ -18,7 +18,7 @@ namespace cellular_setup { ...@@ -18,7 +18,7 @@ namespace cellular_setup {
class FakeOtaActivator : public OtaActivator, public FakeCarrierPortalHandler { class FakeOtaActivator : public OtaActivator, public FakeCarrierPortalHandler {
public: public:
explicit FakeOtaActivator(base::OnceClosure on_finished_callback); explicit FakeOtaActivator(base::OnceClosure on_finished_callback);
~FakeOtaActivator(); ~FakeOtaActivator() override;
using OtaActivator::InvokeOnFinishedCallback; using OtaActivator::InvokeOnFinishedCallback;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment