[iOS][test runner] Copy artifacts for flaky / failed tests.

Test runner will copy attachments from xcresult to output folder
(isolated output in infra) for all failed tests in each attempt.
Screenshots will be collected only from failing steps to avoid noise.
Other attachments will be collected from every step.
- Put the copy logic in private methods and called these in public
collect_test_results.
- Improved and unified variable naming where touched.
- Removed unused plist check where touched.
- Fixed and added tests for xcode_log_parser.

Bug: 1047704
Change-Id: I448c785a256702d93698e5c73ef89b7477efbc87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473499Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819543}

ios/build/bots/scripts/PRESUBMIT.py

@@ -22,7 +22,7 @@ def _RunTestRunnerUnitTests(input_api, output_api):
       'test_apps_test.py',
       # 'test_runner_test.py',
       'wpr_runner_test.py',
-      # 'xcode_log_parser_test.py',
+      'xcode_log_parser_test.py',
       # 'xcodebuild_runner_test.py',
   ]
 

ios/build/bots/scripts/xcodebuild_runner.py

@@ -232,7 +232,6 @@ class LaunchCommand(object):
           if failure:
             LOGGER.info('Failure for passed tests %s: %s' % (status, failure))
         break
-      self._log_parser.copy_screenshots(outdir_attempt)
 
       # If tests are not completed(interrupted or did not start)
       # re-run them with the same number of shards,