Commit b2bdc4e9 authored by Phillis Tang's avatar Phillis Tang Committed by Chromium LUCI CQ

DPWA: add feature promo dialog browsertest for PWA install

Adds a browsertest that enables Skia Gold pixel test for PWA install icon
In-Product Help.

Bug: None
Change-Id: I2ff766a5674d2bed10ac3d2f0cac94d18ce5fca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573384
Commit-Queue: Phillis Tang <phillis@chromium.org>
Reviewed-by: default avatarCollin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835903}
parent 2d9e6987
......@@ -8,15 +8,19 @@
#include "base/bind.h"
#include "base/feature_list.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/banners/test_app_banner_manager_desktop.h"
#include "chrome/browser/feature_engagement/tracker_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/global_media_controls/media_toolbar_button_view.h"
#include "chrome/browser/ui/views/page_action/page_action_icon_controller.h"
#include "chrome/browser/ui/views/page_action/page_action_icon_view.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/browser/ui/views/user_education/feature_promo_controller_views.h"
#include "chrome/common/buildflags.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/feature_engagement/public/feature_list.h"
#include "components/feature_engagement/test/mock_tracker.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
......@@ -41,6 +45,10 @@ class FeaturePromoDialogTest : public DialogBrowserTest {
// screen and remove this.
set_should_verify_dialog_bounds(false);
}
void SetUp() override {
banners::TestAppBannerManagerDesktop::SetUp();
DialogBrowserTest::SetUp();
}
~FeaturePromoDialogTest() override = default;
......@@ -117,6 +125,28 @@ class FeaturePromoDialogTest : public DialogBrowserTest {
// For running your test reference the docs in
// //chrome/browser/ui/test/test_browser_dialog.h
IN_PROC_BROWSER_TEST_F(FeaturePromoDialogTest, InvokeUi_IPH_DesktopPwaInstall) {
set_baseline("2573384");
// Navigate to an installable site so PWA install icon shows up.
ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL("/banners/manifest_test_page.html"));
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
auto* app_banner_manager =
banners::TestAppBannerManagerDesktop::FromWebContents(web_contents);
app_banner_manager->WaitForInstallableCheck();
EXPECT_TRUE(BrowserView::GetBrowserViewForBrowser(browser())
->toolbar()
->location_bar()
->page_action_icon_controller()
->GetIconView(PageActionIconType::kPwaInstall)
->GetVisible());
ShowAndVerifyUi();
}
IN_PROC_BROWSER_TEST_F(FeaturePromoDialogTest,
InvokeUi_IPH_DesktopTabGroupsNewGroup) {
set_baseline("2473537");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment