Commit b2d537e8 authored by W. James MacLean's avatar W. James MacLean Committed by Commit Bot

Disable more NaCl test on Win_32.

Disabling tests that are causing the Win7 32 bot to flake.

TBR=dschuff@chromium.org

Bug: 1059468
Change-Id: I892f60b178ab2383c195377878ead30c0b60417d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390461Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803905}
parent fba45ba9
...@@ -92,6 +92,12 @@ NACL_BROWSER_TEST_F(NaClBrowserTest, PPAPIPPPInstance, { ...@@ -92,6 +92,12 @@ NACL_BROWSER_TEST_F(NaClBrowserTest, PPAPIPPPInstance, {
RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_ppp_instance.html")); RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_ppp_instance.html"));
}) })
// TODO(1059468): Flaky on Win7 (32).
#if defined(OS_WIN) && defined(ARCH_CPU_32_BITS)
#define MAYBE_ProgressEvents DISABLED_ProgressEvents
#else
#define MAYBE_ProgressEvents ProgressEvents
#endif
NACL_BROWSER_TEST_F(NaClBrowserTest, ProgressEvents, { NACL_BROWSER_TEST_F(NaClBrowserTest, ProgressEvents, {
RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_progress_events.html")); RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_progress_events.html"));
}) })
......
...@@ -260,14 +260,14 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestGLibcVcacheExtension, ...@@ -260,14 +260,14 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestGLibcVcacheExtension,
// Test that validation for the 2 (or 3) PNaCl translator nexes can be cached. // Test that validation for the 2 (or 3) PNaCl translator nexes can be cached.
// This includes pnacl-llc.nexe, pnacl-ld.nexe, and possibly pnacl-sz.nexe. // This includes pnacl-llc.nexe, pnacl-ld.nexe, and possibly pnacl-sz.nexe.
// Flaky on Windows https://crbug.com/1059468#c18 // Flaky on Windows https://crbug.com/1059468#c18
#if defined(OS_WIN) #if defined(OS_WIN) && defined(ARCH_CPU_32_BITS)
#define MAYBE_ValidationCacheOfTranslatorNexes \ #define MAYBE_ValidationCacheOfTranslatorNexes \
DISABLED_ValidationCacheOfTranslatorNexes DISABLED_ValidationCacheOfTranslatorNexes
#else #else
#define MAYBE_ValidationCacheOfTranslatorNexes ValidationCacheOfTranslatorNexes #define MAYBE_ValidationCacheOfTranslatorNexes ValidationCacheOfTranslatorNexes
#endif #endif
IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnacl, IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnacl,
ValidationCacheOfTranslatorNexes) { MAYBE_ValidationCacheOfTranslatorNexes) {
const bool uses_subzero_with_o0 = IsSubzeroSupportedForArch(); const bool uses_subzero_with_o0 = IsSubzeroSupportedForArch();
base::HistogramBase::Count subzero_o0_count = (uses_subzero_with_o0 ? 1 : 0); base::HistogramBase::Count subzero_o0_count = (uses_subzero_with_o0 ? 1 : 0);
base::HistogramTester histograms; base::HistogramTester histograms;
...@@ -308,7 +308,6 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnacl, ...@@ -308,7 +308,6 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnacl,
3 + subzero_o0_count); 3 + subzero_o0_count);
} }
// TODO(ncbray) convert the rest of nacl_uma.py (currently in the NaCl repo.) // TODO(ncbray) convert the rest of nacl_uma.py (currently in the NaCl repo.)
// Test validation failures and crashes. // Test validation failures and crashes.
......
...@@ -260,7 +260,10 @@ IN_PROC_BROWSER_TEST_F(PPAPIBrokerInfoBarTest, Allowed) { ...@@ -260,7 +260,10 @@ IN_PROC_BROWSER_TEST_F(PPAPIBrokerInfoBarTest, Allowed) {
RunTest("Broker_IsAllowedPermissionGranted"); RunTest("Broker_IsAllowedPermissionGranted");
} }
// Flaky on Windows https://crbug.com/1059468
#if !defined(OS_WIN) || !defined(ARCH_CPU_32_BITS)
TEST_PPAPI_NACL(Console) TEST_PPAPI_NACL(Console)
#endif
TEST_PPAPI_NACL(Core) TEST_PPAPI_NACL(Core)
...@@ -333,9 +336,12 @@ TEST_PPAPI_NACL(ImageData) ...@@ -333,9 +336,12 @@ TEST_PPAPI_NACL(ImageData)
// failing, and reducing chance of timeout. // failing, and reducing chance of timeout.
PPAPI_SOCKET_TEST(TCPSocket_Connect) PPAPI_SOCKET_TEST(TCPSocket_Connect)
PPAPI_SOCKET_TEST(TCPSocket_ReadWrite) PPAPI_SOCKET_TEST(TCPSocket_ReadWrite)
// Flaky on Windows https://crbug.com/1059468#c18
#if !defined(OS_WIN) || !defined(ARCH_CPU_32_BITS)
PPAPI_SOCKET_TEST(TCPSocket_SetOption) PPAPI_SOCKET_TEST(TCPSocket_SetOption)
PPAPI_SOCKET_TEST(TCPSocket_Listen)
PPAPI_SOCKET_TEST(TCPSocket_Backlog) PPAPI_SOCKET_TEST(TCPSocket_Backlog)
#endif
PPAPI_SOCKET_TEST(TCPSocket_Listen)
PPAPI_SOCKET_TEST(TCPSocket_Interface_1_0) PPAPI_SOCKET_TEST(TCPSocket_Interface_1_0)
PPAPI_SOCKET_TEST(TCPSocket_UnexpectedCalls) PPAPI_SOCKET_TEST(TCPSocket_UnexpectedCalls)
...@@ -1239,9 +1245,12 @@ UDPSOCKET_FAILURE_TEST(UDPSocket_BindError, ...@@ -1239,9 +1245,12 @@ UDPSOCKET_FAILURE_TEST(UDPSocket_BindError,
UDPSOCKET_FAILURE_TEST(UDPSocket_BindDropPipe, UDPSOCKET_FAILURE_TEST(UDPSocket_BindDropPipe,
UDPSocket_BindFails, UDPSocket_BindFails,
WrappedUDPSocket::FailureType::kBindDropPipe) WrappedUDPSocket::FailureType::kBindDropPipe)
// Flaky on Windows https://crbug.com/1059468#c18
#if !defined(OS_WIN) || !defined(ARCH_CPU_32_BITS)
UDPSOCKET_FAILURE_TEST(UDPSocket_SetBroadcastError, UDPSOCKET_FAILURE_TEST(UDPSocket_SetBroadcastError,
UDPSocket_SetBroadcastFails, UDPSocket_SetBroadcastFails,
WrappedUDPSocket::FailureType::kBroadcastError) WrappedUDPSocket::FailureType::kBroadcastError)
#endif
UDPSOCKET_FAILURE_TEST(UDPSocket_SetBroadcastDropPipe, UDPSOCKET_FAILURE_TEST(UDPSocket_SetBroadcastDropPipe,
UDPSocket_SetBroadcastFails, UDPSocket_SetBroadcastFails,
WrappedUDPSocket::FailureType::kBroadcastDropPipe) WrappedUDPSocket::FailureType::kBroadcastDropPipe)
...@@ -1462,9 +1471,12 @@ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(URLLoader1)) { ...@@ -1462,9 +1471,12 @@ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(URLLoader1)) {
RUN_URLLOADER_SUBTESTS_1; RUN_URLLOADER_SUBTESTS_1;
} }
// Flaky on Windows https://crbug.com/1059468#c18
#if !defined(OS_WIN) || !defined(ARCH_CPU_32_BITS)
IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(URLLoader2)) { IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(URLLoader2)) {
RUN_URLLOADER_SUBTESTS_2; RUN_URLLOADER_SUBTESTS_2;
} }
#endif
IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(URLLoader3)) { IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(URLLoader3)) {
RUN_URLLOADER_SUBTESTS_3; RUN_URLLOADER_SUBTESTS_3;
} }
...@@ -1713,9 +1725,12 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, FileRef2) { ...@@ -1713,9 +1725,12 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, FileRef2) {
IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(FileRef1)) { IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(FileRef1)) {
RUN_FILEREF_SUBTESTS_1; RUN_FILEREF_SUBTESTS_1;
} }
// Flaky on Windows https://crbug.com/1059468#c18
#if !defined(OS_WIN) || !defined(ARCH_CPU_32_BITS)
IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(FileRef2)) { IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, MAYBE_PPAPI_NACL(FileRef2)) {
RUN_FILEREF_SUBTESTS_2; RUN_FILEREF_SUBTESTS_2;
} }
#endif
IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, MAYBE_PPAPI_PNACL(FileRef1)) { IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, MAYBE_PPAPI_PNACL(FileRef1)) {
RUN_FILEREF_SUBTESTS_1; RUN_FILEREF_SUBTESTS_1;
} }
...@@ -1956,7 +1971,10 @@ IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest, ...@@ -1956,7 +1971,10 @@ IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest,
RUN_AUDIO_CONFIG_SUBTESTS; RUN_AUDIO_CONFIG_SUBTESTS;
} }
// Flaky on Windows https://crbug.com/1059468#c18
#if !defined(OS_WIN) || !defined(ARCH_CPU_32_BITS)
TEST_PPAPI_NACL(AudioEncoder) TEST_PPAPI_NACL(AudioEncoder)
#endif
// PPB_Audio tests. // PPB_Audio tests.
#define RUN_AUDIO_SUBTESTS \ #define RUN_AUDIO_SUBTESTS \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment