Update PPD file selection text

- Updates label of the PPD file selection for advanced printer dialog
  and for edit printer dialog.
- Learn More link will be updated to point to correct URL.

Bug: 939899
Test: End to End manual
Change-Id: Ie759ae625263ce5f758d3a045b72e1565efeec6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636396Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666100}

chrome/app/settings_strings.grdp

@@ -1483,7 +1483,7 @@
       Manufacturer
     </message>
     <message name="IDS_SETTINGS_PRINTING_CUPS_PRINTER_SELECT_DRIVER" desc="Label for the file selector to manually select a PPD file from the user's file system.">
-      Or specify your own driver:
+      Or specify your printer PPD
     </message>
     <message name="IDS_SETTINGS_PRINTING_CUPS_PRINTER_BUTTON_SELECT_DRIVER" desc="Text for the button which allows user to select a PPD file from the file system.">
       Browse

chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

@@ -170,9 +170,15 @@
               value="{{activePrinter.ppdModel}}">
           </cr-searchable-drop-down>
         </div>
+        <div id="ppdLabel" class="field-label">
+          <span>$i18n{selectDriver}</span>
+          <a href="$i18n{printingCUPSPrintPpdLearnMoreUrl}" target="_blank">
+              $i18n{learnMore}
+          </a>
+        </div>
         <div class="settings-box two-line">
           <cr-input class="browse-file-input" readonly value="[[newUserPPD_]]"
-              label="$i18n{selectDriver}" invalid="[[invalidPPD_]]"
+              aria-labelledby="ppdLabel" invalid="[[invalidPPD_]]"
               error-message="$i18n{selectDriverErrorMessage}" tabindex="-1">
           </cr-input>
           <paper-button class="browse-button" on-click="onBrowseFile_">

chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html

@@ -97,9 +97,15 @@
               value="{{pendingPrinter_.ppdModel}}">
           </cr-searchable-drop-down>
         </div>
+        <div id="ppdLabel" class="field-label">
+          <span>$i18n{selectDriver}</span>
+          <a href="$i18n{printingCUPSPrintPpdLearnMoreUrl}" target="_blank">
+              $i18n{learnMore}
+          </a>
+        </div>
         <div class="settings-box two-line">
           <cr-input class="browse-file-input" readonly tabindex="-1"
-              value="[[userPPD_]]" label="$i18n{selectDriver}"
+              value="[[userPPD_]]" aria-labelledby="ppdLabel"
               error-message="$i18n{selectDriverErrorMessage}"
               invalid="[[invalidPPD_]]">
           </cr-input>

chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html

@@ -93,6 +93,11 @@
       #search input[type='search'] {
         font: inherit;
       }
+
+      .field-label {
+        padding-inline-start: 20px;
+        @apply --cr-form-field-label;
+      }
     </style>
   </template>
 </dom-module>

chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc

@@ -2142,6 +2142,9 @@ void AddPrintingStrings(content::WebUIDataSource* html_source) {
 #if defined(OS_CHROMEOS)
   html_source->AddString("printingCUPSPrintLearnMoreUrl",
                          GetHelpUrlWithBoard(chrome::kCupsPrintLearnMoreURL));
+  html_source->AddString(
+      "printingCUPSPrintPpdLearnMoreUrl",
+      GetHelpUrlWithBoard(chrome::kCupsPrintPPDLearnMoreURL));
 #endif
 }
 

chrome/common/url_constants.cc

@@ -285,6 +285,9 @@ const char kCrosScheme[] = "cros";
 const char kCupsPrintLearnMoreURL[] =
     "https://support.google.com/chromebook?p=chromebook_printing";
 
+const char kCupsPrintPPDLearnMoreURL[] =
+    "https://support.google.com/chromebook?p=chromebook_printing";
+
 const char kEasyUnlockLearnMoreUrl[] =
     "https://support.google.com/chromebook/?p=smart_lock";
 

chrome/common/url_constants.h

@@ -230,6 +230,8 @@ extern const char kCrosScheme[];
 
 extern const char kCupsPrintLearnMoreURL[];
 
+extern const char kCupsPrintPPDLearnMoreURL[];
+
 // The URL for the "Learn more" link the the Easy Unlock settings.
 extern const char kEasyUnlockLearnMoreUrl[];