Commit b2e9e89a authored by Joe DeBlasio's avatar Joe DeBlasio Committed by Commit Bot

Safety Tip: Switch to shield on Android infobar.

This CL swaps the lightbulb icon for the new hybrid shield-bulb and
switches to the "big icon" infobar.  This CL also removes the lightbulb
icon from Android, since nothing is using it anymore.

Bug: 1000337
Change-Id: Iabacf98e0a568bfaff03e8e6a0318f055cfe74a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783279Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696995}
parent 2b6f8dea
...@@ -55,6 +55,7 @@ public class SafetyTipInfoBar extends ConfirmInfoBar { ...@@ -55,6 +55,7 @@ public class SafetyTipInfoBar extends ConfirmInfoBar {
@Override @Override
public void createContent(InfoBarLayout layout) { public void createContent(InfoBarLayout layout) {
super.createContent(layout); super.createContent(layout);
layout.setIsUsingBigIcon();
layout.getMessageLayout().addDescription(mDescription); layout.getMessageLayout().addDescription(mDescription);
} }
} }
...@@ -55,10 +55,10 @@ DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_PREVIEWS, ...@@ -55,10 +55,10 @@ DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_PREVIEWS,
R.drawable.infobar_chrome) R.drawable.infobar_chrome)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_PROTECTED_MEDIA_IDENTIFIER, DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_PROTECTED_MEDIA_IDENTIFIER,
R.drawable.infobar_protected_media_identifier) R.drawable.infobar_protected_media_identifier)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_SAFETYTIP_SHIELD,
R.drawable.safetytip_shield)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_SAVE_PASSWORD, DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_SAVE_PASSWORD,
R.drawable.ic_vpn_key_blue) R.drawable.ic_vpn_key_blue)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_TIP,
R.drawable.ic_lightbulb_outline_googblue_24dp)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_TRANSLATE, R.drawable.infobar_translate) DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_TRANSLATE, R.drawable.infobar_translate)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_WARNING, R.drawable.infobar_warning) DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_WARNING, R.drawable.infobar_warning)
DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_PHONE_ICON, DECLARE_RESOURCE_ID(IDR_ANDROID_INFOBAR_PHONE_ICON,
......
...@@ -96,7 +96,7 @@ SafetyTipInfoBarDelegate::GetIdentifier() const { ...@@ -96,7 +96,7 @@ SafetyTipInfoBarDelegate::GetIdentifier() const {
} }
int SafetyTipInfoBarDelegate::GetIconId() const { int SafetyTipInfoBarDelegate::GetIconId() const {
return IDR_ANDROID_INFOBAR_TIP; return IDR_ANDROID_INFOBAR_SAFETYTIP_SHIELD;
} }
void SafetyTipInfoBarDelegate::InfoBarDismissed() { void SafetyTipInfoBarDelegate::InfoBarDismissed() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment