Commit b2f7b933 authored by Ryan Hamilton's avatar Ryan Hamilton Committed by Commit Bot

Enable QUIC v99 flag

Fix a P2PQuic test to correctly grok v99 RST_STREAM semantics.

Change-Id: I7c200aa575926396f814d3d9de3ca460b3723b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825657Reviewed-by: default avatarZhongyi Shi <zhongyi@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701579}
parent 4a11dace
......@@ -76,7 +76,7 @@ QUIC_FLAG(int32_t, FLAGS_quic_anti_amplification_factor, 3)
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr_less_probe_rtt, false)
// If true, enable QUIC v99.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_version_99, false)
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_version_99, true)
// When true, set the initial congestion control window from connection options
// in QuicSentPacketManager rather than TcpCubicSenderBytes.
......
......@@ -174,7 +174,23 @@ TEST_F(P2PQuicStreamTest, StreamClosedAfterReceivingReset) {
quic::QuicRstStreamFrame rst_frame(quic::kInvalidControlFrameId, kStreamId,
quic::QUIC_STREAM_CANCELLED, 0);
if (!VersionHasIetfQuicFrames(connection_->version().transport_version)) {
// Google RST_STREAM closes the stream in both directions. A RST_STREAM
// is then sent to the peer to communicate the final byte offset.
EXPECT_CALL(session_,
SendRstStream(kStreamId, quic::QUIC_RST_ACKNOWLEDGEMENT, 0));
}
stream_->OnStreamReset(rst_frame);
if (VersionHasIetfQuicFrames(connection_->version().transport_version)) {
// In IETF QUIC, the RST_STREAM only closes the stream in one direction.
// A STOP_SENDING frame in require to induce the a RST_STREAM being
// send to close the other direction.
EXPECT_CALL(*connection_, SendControlFrame(_));
EXPECT_CALL(*connection_, OnStreamReset(kStreamId, testing::_));
quic::QuicStopSendingFrame stop_sending_frame(quic::kInvalidControlFrameId,
kStreamId, 0);
session_.OnStopSendingFrame(stop_sending_frame);
}
EXPECT_TRUE(stream_->IsClosedForTesting());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment