Commit b2f9ade9 authored by Matt Reynolds's avatar Matt Reynolds Committed by Commit Bot

Improve gamepad-polling-access layout test

Under normal circumstances, gamepad state can only change in
response to certain triggers. By using the gamepadController test
API, the gamepad state may be changed in response to many more
triggers, including gamepad events themselves, which may cause
some events to not be dispatched. This CL modifies the layout test
to only change gamepad state outside of gamepad event listeners.

This CL also removes a hack where the string representation of the
gamepad state was being compared instead of the underlying buffers.
This hack was intended as a workaround for a bug caused by incorrect
buffer reuse behavior. The bug still exists but the test is modified
to test the reuse behavior as intended.

BUG=855760

Change-Id: I75144ae68efa355992d03692e2fd52b2f832281f
Reviewed-on: https://chromium-review.googlesource.com/1173329
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583428}
parent a67d0227
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment