Commit b305aa5d authored by Robbie Gibson's avatar Robbie Gibson Committed by Commit Bot

[iOS] Disable testDialog* QRScanner tests on EG2 and iOS 12

Bug: 1019211
Change-Id: I2df1ed99e225bbd6b7e480388828632b7d6ef13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890412
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710773}
parent 6ff97867
......@@ -569,7 +569,13 @@ void TapKeyboardReturnKeyInOmniboxWithText(std::string text) {
// Tests that a UIAlertController is presented by the QRScannerViewController if
// the camera state changes after the QRScannerViewController is presented.
// TODO(crbug.com/1019211): Re-enable test on iOS12.
- (void)testDialogIsDisplayedIfCameraStateChanges {
#if defined(CHROME_EARL_GREY_2)
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
id cameraControllerMock =
[QRScannerAppInterface cameraControllerMockWithAuthorizationStatus:
AVAuthorizationStatusAuthorized];
......@@ -602,7 +608,13 @@ void TapKeyboardReturnKeyInOmniboxWithText(std::string text) {
}
// Tests that a new dialog replaces an old dialog if the camera state changes.
// TODO(crbug.com/1019211): Re-enable test on iOS12.
- (void)testDialogIsReplacedIfCameraStateChanges {
#if defined(CHROME_EARL_GREY_2)
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
id cameraControllerMock =
[QRScannerAppInterface cameraControllerMockWithAuthorizationStatus:
AVAuthorizationStatusAuthorized];
......@@ -643,11 +655,11 @@ void TapKeyboardReturnKeyInOmniboxWithText(std::string text) {
// Tests that an error dialog is dismissed if the camera becomes available.
// TODO(crbug.com/1019211): Re-enable test on iOS12.
- (void)testDialogDismissedIfCameraBecomesAvailable {
#if TARGET_IPHONE_SIMULATOR
#if defined(CHROME_EARL_GREY_2)
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails iOS 12.2");
}
#endif // TARGET_IPHONE_SIMULATOR
#endif // defined(CHROME_EARL_GREY_2)
id cameraControllerMock =
[QRScannerAppInterface cameraControllerMockWithAuthorizationStatus:
AVAuthorizationStatusAuthorized];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment