Reland "Android: Private-package Tab.setIsShowingErroPage"
This reverts commit 62dae75f. Reason for revert: this time will land the internal cl https://crrev.com/i/2015128 asap to keep the build green Original change's description: > Revert "Android: Private-package Tab.setIsShowingErroPage" > > This reverts commit 1e252fbf. > > Reason for revert: this change broke the internal build https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/b8898843520461106640 > > Also, TabTestUtils.setIsShowingErrorPage() isn't defined as static, so the error couldn't be fixed in 1 internal CL. > > Original change's description: > > Android: Private-package Tab.setIsShowingErroPage > > > > The method is called by a class in chrome.browser.tab package > > in production code. Makes it a private-package method. > > > > Bug: 995903 > > Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#708466} > > TBR=dtrainor@chromium.org,jinsukkim@chromium.org > > Change-Id: Ieed0cf2e34f59cf4f7e68a4eb44dea0ea2f561aa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 995903 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876389 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708594} TBR=dtrainor@chromium.org,jinsukkim@chromium.org,alexilin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 995903 Change-Id: I28634b5fd495b50823158f34589c032e472d988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880231Reviewed-by:Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#709332}
Showing
Please register or sign in to comment