Commit b31c0876 authored by Vasiliy Telezhnikov's avatar Vasiliy Telezhnikov Committed by Commit Bot

aw: Crash on context lost earlier

This CL changes NOTREACHED() to LOG(FATAL) in context lost handling on
RenderThread. WebView currently will intentionally crash in
HardwareRendererViz::OnViz::DisplayOutputSurfaceLost, but it happens on
viz thread later and has no useful information.

Bug: 1112841
Change-Id: I2548c06c32897d586e9d51d143d1dbd2f3fdfc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392411Reviewed-by: default avatarBo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804379}
parent d69ed658
......@@ -29,7 +29,12 @@ namespace android_webview {
namespace {
void OnContextLost(bool synthetic_loss) {
NOTREACHED() << "Non owned context lost!";
// TODO(https://crbug.com/1112841): Debugging contexts losts. WebView will
// intentionally crash in HardwareRendererViz::OnViz::DisplayOutputSurface
// that will happen after this callback. That crash happens on viz thread and
// doesn't have any useful information. Crash here on RenderThread to
// understand the reason of context losts.
LOG(FATAL) << "Non owned context lost!";
}
} // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment