Commit b327e697 authored by ojan@chromium.org's avatar ojan@chromium.org

Update comment now that I understand it better.

Review URL: https://codereview.chromium.org/319383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175814 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 34cdb918
...@@ -448,8 +448,9 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand): ...@@ -448,8 +448,9 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
# This is so we remove lines for builders that skip this test, e.g. Android skips most # This is so we remove lines for builders that skip this test, e.g. Android skips most
# tests and we don't want to leave stray [ Android ] lines in TestExpectations.. # tests and we don't want to leave stray [ Android ] lines in TestExpectations..
# FIXME: Is this necessary at all now that _rebaseline_commands includes the builders that # This is only necessary for "webkit-patch rebaseline" and for rebaselining expected
# used to be skipped because the result wasn't failing on tip of tree? # failures from garden-o-matic. rebaseline-expectations and auto-rebaseline will always
# pass the exact set of ports to rebaseline.
for port_name in self._tool.port_factory.all_port_names(): for port_name in self._tool.port_factory.all_port_names():
port = self._tool.port_factory.get(port_name) port = self._tool.port_factory.get(port_name)
generic_expectations = TestExpectations(port, tests=tests, include_overrides=False) generic_expectations = TestExpectations(port, tests=tests, include_overrides=False)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment