Revert 148383 - Move the keyboard overlay view to ash.

This change introduces an issue when Shift+Alt  is pressed (http://code.google.com/p/chromium/issues/detail?id=131159).
I'll fix it shortly together with the more general issue (http://code.google.com/p/chromium/issues/detail?id=129834).

BUG=124222
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10829003

TBR=mazda@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148385 0039d316-1c4b-4281-b951-d872f2087c98

ash/DEPS

 include_rules = [
   "+chromeos",
-  "+content/public",
   "+grit/ash_strings.h",
   "+grit/ui_resources.h",
   "+grit/ui_strings.h",

ash/ash.gyp

@@ -110,10 +110,6 @@
         'display/screen_position_controller.h',
         'display/secondary_display_view.cc',
         'display/secondary_display_view.h',
-        'keyboard_overlay/keyboard_overlay_delegate.cc',
-        'keyboard_overlay/keyboard_overlay_delegate.h',
-        'keyboard_overlay/keyboard_overlay_view.cc',
-        'keyboard_overlay/keyboard_overlay_view.h',
         'root_window_controller.cc',
         'root_window_controller.h',
         'rotator/screen_rotation.cc',

ash/ash_strings.grd

@@ -200,10 +200,6 @@ This file contains the strings for ash.
         Pull down to minimize, left or right to tile
       </message>
 
-      <message name="IDS_ASH_KEYBOARD_OVERLAY_TITLE" desc="The title of the keyboard overlay.">
-        Keyboard Overlay
-      </message>
-
       <!-- Status tray items -->
       <message name="IDS_ASH_STATUS_TRAY_ACCESSIBLE_NAME" desc="The accessible name of the status tray.">
         Status tray

chrome/browser/ui/views/ash/chrome_shell_delegate.cc

@@ -34,7 +34,6 @@
 #include "ui/aura/window.h"
 
 #if defined(OS_CHROMEOS)
-#include "ash/keyboard_overlay/keyboard_overlay_view.h"
 #include "base/chromeos/chromeos_version.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
 #include "chrome/browser/chromeos/background/ash_user_wallpaper_delegate.h"
@@ -43,6 +42,7 @@
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/login/webui_login_display_host.h"
 #include "chrome/browser/chromeos/system/ash_system_tray_delegate.h"
+#include "chrome/browser/ui/views/keyboard_overlay_dialog_view.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chrome/browser/ui/webui/chromeos/mobile_setup_dialog.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
@@ -262,12 +262,8 @@ bool ChromeShellDelegate::RotatePaneFocus(ash::Shell::Direction direction) {
 
 void ChromeShellDelegate::ShowKeyboardOverlay() {
 #if defined(OS_CHROMEOS)
-  // TODO(mazda): Move the show logic to ash (http://crbug.com/124222).
   Profile* profile = ProfileManager::GetDefaultProfileOrOffTheRecord();
-  std::string url(chrome::kChromeUIKeyboardOverlayURL);
-  KeyboardOverlayView::ShowDialog(profile,
-                                  new ChromeWebContentsHandler,
-                                  GURL(url));
+  KeyboardOverlayDialogView::ShowDialog(profile, new ChromeWebContentsHandler);
 #endif
 }
 

ash/keyboard_overlay/keyboard_overlay_delegate.cc → chrome/browser/ui/views/keyboard_overlay_delegate.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ash/keyboard_overlay/keyboard_overlay_delegate.h"
+#include "chrome/browser/ui/views/keyboard_overlay_delegate.h"
 
 #include <algorithm>
 
@@ -10,8 +10,11 @@
 #include "base/memory/weak_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "chrome/common/url_constants.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_message_handler.h"
+#include "googleurl/src/gurl.h"
+#include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/controls/webview/web_dialog_view.h"
@@ -58,10 +61,8 @@ void PaintMessageHandler::DidPaint(const ListValue* args) {
 
 }  // namespace
 
-KeyboardOverlayDelegate::KeyboardOverlayDelegate(const string16& title,
-                                                 const GURL& url)
+KeyboardOverlayDelegate::KeyboardOverlayDelegate(const string16& title)
     : title_(title),
-      url_(url),
       view_(NULL) {
 }
 
@@ -100,7 +101,8 @@ string16 KeyboardOverlayDelegate::GetDialogTitle() const {
 }
 
 GURL KeyboardOverlayDelegate::GetDialogContentURL() const {
-  return url_;
+  std::string url_string(chrome::kChromeUIKeyboardOverlayURL);
+  return GURL(url_string);
 }
 
 void KeyboardOverlayDelegate::GetWebUIMessageHandlers(

ash/keyboard_overlay/keyboard_overlay_delegate.h → chrome/browser/ui/views/keyboard_overlay_delegate.h

@@ -2,12 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef ASH_KEYBOARD_OVERLAY_KEYBOARD_OVERLAY_DELEGATE_H_
-#define ASH_KEYBOARD_OVERLAY_KEYBOARD_OVERLAY_DELEGATE_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DELEGATE_H_
+#define CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DELEGATE_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
-#include "googleurl/src/gurl.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
 
 namespace views {
@@ -16,7 +15,7 @@ class WebDialogView;
 
 class KeyboardOverlayDelegate : public ui::WebDialogDelegate {
  public:
-  KeyboardOverlayDelegate(const string16& title, const GURL& url);
+  explicit KeyboardOverlayDelegate(const string16& title);
 
   void Show(views::WebDialogView* view);
 
@@ -43,9 +42,6 @@ class KeyboardOverlayDelegate : public ui::WebDialogDelegate {
   // The dialog title.
   string16 title_;
 
-  // The URL of the keyboard overlay.
-  GURL url_;
-
   // The view associated with this delegate.
   // This class does not own the pointer.
   views::WebDialogView* view_;
@@ -53,4 +49,4 @@ class KeyboardOverlayDelegate : public ui::WebDialogDelegate {
   DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayDelegate);
 };
 
-#endif  // ASH_KEYBOARD_OVERLAY_KEYBOARD_OVERLAY_DELEGATE_H_
+#endif  // CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DELEGATE_H_

ash/keyboard_overlay/keyboard_overlay_view.cc → chrome/browser/ui/views/keyboard_overlay_dialog_view.cc

@@ -2,51 +2,64 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ash/keyboard_overlay/keyboard_overlay_view.h"
+#include "chrome/browser/ui/views/keyboard_overlay_dialog_view.h"
 
-#include "ash/keyboard_overlay/keyboard_overlay_delegate.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/ui/views/keyboard_overlay_delegate.h"
 #include "content/public/browser/browser_context.h"
-#include "grit/ash_strings.h"
+#include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/widget/widget.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/input_method/input_method_manager.h"
+#endif
+
 using ui::WebDialogDelegate;
 
 namespace {
 // Store the pointer to the view currently shown.
-KeyboardOverlayView* g_instance = NULL;
+KeyboardOverlayDialogView* g_instance = NULL;
 }
 
-KeyboardOverlayView::KeyboardOverlayView(
+KeyboardOverlayDialogView::KeyboardOverlayDialogView(
     content::BrowserContext* context,
     WebDialogDelegate* delegate,
     WebContentsHandler* handler)
     : views::WebDialogView(context, delegate, handler) {
 }
 
-KeyboardOverlayView::~KeyboardOverlayView() {
+KeyboardOverlayDialogView::~KeyboardOverlayDialogView() {
 }
 
-void KeyboardOverlayView::ShowDialog(
+void KeyboardOverlayDialogView::ShowDialog(
     content::BrowserContext* context,
-    WebContentsHandler* handler,
-    const GURL& url) {
+    WebContentsHandler* handler) {
   // Ignore the call if another view is already shown.
   if (g_instance)
     return;
 
+#if defined(OS_CHROMEOS)
+  // Temporarily disable all accelerators for IME switching including Shift+Alt
+  // since the user might press Shift+Alt to remember an accelerator that starts
+  // with Shift+Alt (e.g. Shift+Alt+Tab for moving focus backwards).
+  chromeos::input_method::InputMethodManager::GetInstance()->DisableHotkeys();
+#endif
   KeyboardOverlayDelegate* delegate = new KeyboardOverlayDelegate(
-      l10n_util::GetStringUTF16(IDS_ASH_KEYBOARD_OVERLAY_TITLE), url);
-  KeyboardOverlayView* view =
-      new KeyboardOverlayView(context, delegate, handler);
+      l10n_util::GetStringUTF16(IDS_KEYBOARD_OVERLAY_TITLE));
+  KeyboardOverlayDialogView* view =
+      new KeyboardOverlayDialogView(context, delegate, handler);
   delegate->Show(view);
 
   g_instance = view;
 }
 
-void KeyboardOverlayView::WindowClosing() {
+void KeyboardOverlayDialogView::WindowClosing() {
+#if defined(OS_CHROMEOS)
+  // Re-enable the IME accelerators. See the comment in ShowDialog() above.
+  chromeos::input_method::InputMethodManager::GetInstance()->EnableHotkeys();
+#endif
   g_instance = NULL;
 }

ash/keyboard_overlay/keyboard_overlay_view.h → chrome/browser/ui/views/keyboard_overlay_dialog_view.h

@@ -2,15 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef ASH_KEYBOARD_OVERLAY_KEYBOARD_OVERLAY_VIEW_H_
-#define ASH_KEYBOARD_OVERLAY_KEYBOARD_OVERLAY_VIEW_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DIALOG_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DIALOG_VIEW_H_
 
-#include "ash/ash_export.h"
 #include "base/compiler_specific.h"
 #include "ui/views/controls/webview/web_dialog_view.h"
 
-class GURL;
-
 namespace content {
 class BrowserContext;
 }
@@ -20,23 +17,22 @@ class WebDialogDelegate;
 }
 
 // A customized dialog view for the keyboard overlay.
-class ASH_EXPORT KeyboardOverlayView : public views::WebDialogView {
+class KeyboardOverlayDialogView : public views::WebDialogView {
  public:
-  KeyboardOverlayView(content::BrowserContext* context,
-                      ui::WebDialogDelegate* delegate,
-                      WebContentsHandler* handler);
-  virtual ~KeyboardOverlayView();
+  KeyboardOverlayDialogView(content::BrowserContext* context,
+                            ui::WebDialogDelegate* delegate,
+                            WebContentsHandler* handler);
+  virtual ~KeyboardOverlayDialogView();
 
   // Shows the keyboard overlay.
   static void ShowDialog(content::BrowserContext* context,
-                         WebContentsHandler* handler,
-                         const GURL& url);
+                         WebContentsHandler* handler);
 
  private:
   // Overridden from views::WidgetDelegate:
   virtual void WindowClosing() OVERRIDE;
 
-  DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayView);
+  DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayDialogView);
 };
 
-#endif  // ASH_KEYBOARD_OVERLAY_KEYBOARD_OVERLAY_VIEW_H_
+#endif  // CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DIALOG_VIEW_H_

chrome/chrome_browser.gypi

@@ -3712,6 +3712,10 @@
         'browser/ui/views/infobars/translate_message_infobar.h',
         'browser/ui/views/javascript_app_modal_dialog_views.cc',
         'browser/ui/views/javascript_app_modal_dialog_views.h',
+        'browser/ui/views/keyboard_overlay_delegate.cc',
+        'browser/ui/views/keyboard_overlay_delegate.h',
+        'browser/ui/views/keyboard_overlay_dialog_view.cc',
+        'browser/ui/views/keyboard_overlay_dialog_view.h',
         'browser/ui/views/location_bar/action_box_button_view.cc',
         'browser/ui/views/location_bar/action_box_button_view.h',
         'browser/ui/views/location_bar/chrome_to_mobile_view.cc',
@@ -5163,6 +5167,8 @@
             'browser/ui/crypto_module_password_dialog.cc',
             'browser/ui/crypto_module_password_dialog_nss.cc',
             'browser/ui/startup/autolaunch_prompt.cc',
+            'browser/ui/views/keyboard_overlay_delegate.cc',
+            'browser/ui/views/keyboard_overlay_dialog_view.cc',
             'browser/ui/views/simple_message_box_views.cc',
             'browser/ui/webui/help/version_updater_basic.cc',
             'browser/ui/webui/help/version_updater_basic.h',
@@ -5239,6 +5245,10 @@
               'sources/': [
                 ['exclude', '^browser/chromeos/extensions/file_browser_handler_api'],
                 ['exclude', '^browser/chromeos/extensions/file_browser_private_api'],
+                ['exclude', '^browser/ui/views/keyboard_overlay_delegate.cc'],
+                ['exclude', '^browser/ui/views/keyboard_overlay_delegate.h'],
+                ['exclude', '^browser/ui/views/keyboard_overlay_dialog_view.cc'],
+                ['exclude', '^browser/ui/views/keyboard_overlay_dialog_view.h'],
               ],
             }],
             # GTK build only