Commit b387bc47 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

Revert "Disable FolderShortcuts/FilesAppBrowserTest on ASan"

This reverts commit 210d3b47.

Reason for revert: https://crbug.com/852246#c12, this issue was fixed
already, no need to revert. "Slowness and times out": not so per the
logs. They were reporting JS exceptions were being thrown in test due to JS Array being 'undefined', issue 852246.

Original change's description:
> Disable FolderShortcuts/FilesAppBrowserTest on ASan
> 
> It's too slow and times out.
> 
> TBR=fukino@chromium.org
> 
> Bug: 851988
> Change-Id: I868d846e3fae5f7dd16b2a2c7203602008221396
> Reviewed-on: https://chromium-review.googlesource.com/1104424
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567991}

TBR=fukino@chromium.org,treib@chromium.org

Change-Id: Ia287519344b7aeecc03da8539fc4448e1224c740
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851988, 852246
Reviewed-on: https://chromium-review.googlesource.com/1105537Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568261}
parent 36b8980c
......@@ -323,12 +323,6 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestCase("genericTaskIsNotExecuted"),
TestCase("genericTaskAndNonGenericTask")));
// TODO(crbug.com/851988): Times out on ASan.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_FilesAppBrowserTest DISABLED_FilesAppBrowserTest
#else
#define MAYBE_FilesAppBrowserTest FilesAppBrowserTest
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
FolderShortcuts, /* folder_shortcuts.js */
FilesAppBrowserTest,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment