Remove mutableResourceRequest() by FetchRequest::setRequestContext()

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext(), to limit the ways to
modify a ResourceRequest after it is put in a FetchRequest.

BUG=632580

Review-Url: https://codereview.chromium.org/2741753003
Cr-Commit-Position: refs/heads/master@{#456208}

third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp

@@ -41,8 +41,7 @@ CSSStyleSheetResource* CSSStyleSheetResource::fetch(FetchRequest& request,
                                                     ResourceFetcher* fetcher) {
   DCHECK_EQ(request.resourceRequest().frameType(),
             WebURLRequest::FrameTypeNone);
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextStyle);
+  request.setRequestContext(WebURLRequest::RequestContextStyle);
   CSSStyleSheetResource* resource = toCSSStyleSheetResource(
       fetcher->requestResource(request, CSSStyleSheetResourceFactory()));
   // TODO(kouhei): Dedupe this logic w/ ScriptResource::fetch

third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp

@@ -34,8 +34,7 @@ DocumentResource* DocumentResource::fetchSVGDocument(FetchRequest& request,
                                                      ResourceFetcher* fetcher) {
   DCHECK_EQ(request.resourceRequest().frameType(),
             WebURLRequest::FrameTypeNone);
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextImage);
+  request.setRequestContext(WebURLRequest::RequestContextImage);
   return toDocumentResource(
       fetcher->requestResource(request, SVGDocumentResourceFactory()));
 }

third_party/WebKit/Source/core/loader/resource/FontResource.cpp

@@ -77,8 +77,7 @@ FontResource* FontResource::fetch(FetchRequest& request,
                                   ResourceFetcher* fetcher) {
   DCHECK_EQ(request.resourceRequest().frameType(),
             WebURLRequest::FrameTypeNone);
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextFont);
+  request.setRequestContext(WebURLRequest::RequestContextFont);
   return toFontResource(
       fetcher->requestResource(request, FontResourceFactory()));
 }

third_party/WebKit/Source/core/loader/resource/ImageResource.cpp

@@ -151,8 +151,7 @@ ImageResource* ImageResource::fetch(FetchRequest& request,
                                     ResourceFetcher* fetcher) {
   if (request.resourceRequest().requestContext() ==
       WebURLRequest::RequestContextUnspecified) {
-    request.mutableResourceRequest().setRequestContext(
-        WebURLRequest::RequestContextImage);
+    request.setRequestContext(WebURLRequest::RequestContextImage);
   }
   if (fetcher->context().pageDismissalEventBeingDispatched()) {
     KURL requestURL = request.resourceRequest().url();

third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp

@@ -41,8 +41,7 @@ ScriptResource* ScriptResource::fetch(FetchRequest& request,
                                       ResourceFetcher* fetcher) {
   DCHECK_EQ(request.resourceRequest().frameType(),
             WebURLRequest::FrameTypeNone);
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextScript);
+  request.setRequestContext(WebURLRequest::RequestContextScript);
   ScriptResource* resource = toScriptResource(
       fetcher->requestResource(request, ScriptResourceFactory()));
   if (resource && !request.integrityMetadata().isEmpty())

third_party/WebKit/Source/platform/loader/fetch/FetchRequest.h

@@ -81,6 +81,10 @@ class PLATFORM_EXPORT FetchRequest {
   const ResourceRequest& resourceRequest() const { return m_resourceRequest; }
   const KURL& url() const { return m_resourceRequest.url(); }
 
+  void setRequestContext(WebURLRequest::RequestContext context) {
+    m_resourceRequest.setRequestContext(context);
+  }
+
   const String& charset() const { return m_charset; }
   void setCharset(const String& charset) { m_charset = charset; }
 

third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp

@@ -46,8 +46,7 @@ RawResource* RawResource::fetchImport(FetchRequest& request,
                                       ResourceFetcher* fetcher) {
   DCHECK_EQ(request.resourceRequest().frameType(),
             WebURLRequest::FrameTypeNone);
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextImport);
+  request.setRequestContext(WebURLRequest::RequestContextImport);
   return toRawResource(fetcher->requestResource(
       request, RawResourceFactory(Resource::ImportResource)));
 }
@@ -101,8 +100,7 @@ RawResource* RawResource::fetchTextTrack(FetchRequest& request,
                                          ResourceFetcher* fetcher) {
   DCHECK_EQ(request.resourceRequest().frameType(),
             WebURLRequest::FrameTypeNone);
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextTrack);
+  request.setRequestContext(WebURLRequest::RequestContextTrack);
   return toRawResource(fetcher->requestResource(
       request, RawResourceFactory(Resource::TextTrack)));
 }

third_party/WebKit/Source/platform/loader/testing/MockResource.cpp

@@ -28,8 +28,7 @@ class MockResourceFactory final : public ResourceFactory {
 // static
 MockResource* MockResource::fetch(FetchRequest& request,
                                   ResourceFetcher* fetcher) {
-  request.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextSubresource);
+  request.setRequestContext(WebURLRequest::RequestContextSubresource);
   Resource* resource = fetcher->requestResource(request, MockResourceFactory());
   return static_cast<MockResource*>(resource);
 }

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -8246,8 +8246,7 @@ TEST_P(ParameterizedWebFrameTest, NotifyManifestChange) {
 static Resource* fetchManifest(Document* document, const KURL& url) {
   FetchRequest fetchRequest =
       FetchRequest(ResourceRequest(url), FetchInitiatorInfo());
-  fetchRequest.mutableResourceRequest().setRequestContext(
-      WebURLRequest::RequestContextManifest);
+  fetchRequest.setRequestContext(WebURLRequest::RequestContextManifest);
 
   return RawResource::fetchSynchronously(fetchRequest, document->fetcher());
 }