Commit b3b192fa authored by Tommy C. Li's avatar Tommy C. Li Committed by Commit Bot

[omnibox] Enable the Remove Suggestion UI Flag by default

This feature surfaces an X button next to deletable suggestions in the
omnibox.

Enable this flag by default for rollout with M83.

Bug: 1205
Change-Id: Ic3f18d20aeef3959b8ff3f7ab1338bb17db1ca33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124907Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754200}
parent 37deaaed
...@@ -2799,9 +2799,8 @@ const char kOmniboxShortBookmarkSuggestionsDescription[] = ...@@ -2799,9 +2799,8 @@ const char kOmniboxShortBookmarkSuggestionsDescription[] =
const char kOmniboxSuggestionTransparencyOptionsName[] = const char kOmniboxSuggestionTransparencyOptionsName[] =
"Omnibox Suggestion Transparency Options"; "Omnibox Suggestion Transparency Options";
const char kOmniboxSuggestionTransparencyOptionsDescription[] = const char kOmniboxSuggestionTransparencyOptionsDescription[] =
"Improves transparency of and control over omnibox suggestions. This " "Surfaces an X button next to deletable omnibox suggestions. This is to "
"includes \"Why this Suggestion?\" and user controls to delete " "make the suggestion removal feature more discoverable.";
"personalized suggestions.";
const char kOmniboxTabSwitchSuggestionsName[] = const char kOmniboxTabSwitchSuggestionsName[] =
"Omnibox tab switch suggestions"; "Omnibox tab switch suggestions";
......
...@@ -124,11 +124,10 @@ const base::Feature kExperimentalKeywordMode{"OmniboxExperimentalKeywordMode", ...@@ -124,11 +124,10 @@ const base::Feature kExperimentalKeywordMode{"OmniboxExperimentalKeywordMode",
const base::Feature kOmniboxPedalSuggestions{"OmniboxPedalSuggestions", const base::Feature kOmniboxPedalSuggestions{"OmniboxPedalSuggestions",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
// Feature used for UI that improves transparency of and control over omnibox // Feature that surfaces an X button next to deletable omnibox suggestions.
// suggestions. This includes "Why this Suggestion?" and user controls to delete // This is to make the suggestion removal feature more discoverable.
// personalized suggestions. This will be eventually enabled by default.
const base::Feature kOmniboxSuggestionTransparencyOptions{ const base::Feature kOmniboxSuggestionTransparencyOptions{
"OmniboxSuggestionTransparencyOptions", base::FEATURE_DISABLED_BY_DEFAULT}; "OmniboxSuggestionTransparencyOptions", base::FEATURE_ENABLED_BY_DEFAULT};
// Feature to enable clipboard provider to suggest searching for copied images. // Feature to enable clipboard provider to suggest searching for copied images.
const base::Feature kEnableClipboardProviderImageSuggestions{ const base::Feature kEnableClipboardProviderImageSuggestions{
......
...@@ -3653,7 +3653,6 @@ ...@@ -3653,7 +3653,6 @@
"OmniboxOnFocusSuggestions", "OmniboxOnFocusSuggestions",
"OmniboxRemoveSuggestionsFromClipboard", "OmniboxRemoveSuggestionsFromClipboard",
"OmniboxRichEntitySuggestions", "OmniboxRichEntitySuggestions",
"OmniboxSuggestionTransparencyOptions",
"OmniboxUIExperimentMaxAutocompleteMatches", "OmniboxUIExperimentMaxAutocompleteMatches",
"QueryInOmnibox" "QueryInOmnibox"
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment