Commit b3ba5599 authored by David Maunder's avatar David Maunder Committed by Commit Bot

Add scoped TraceEvent to PersistedTabData serialization methods

Bug: 1122629
Change-Id: Ifa83a9f981551037d16c73907665f2b2faa1323b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380253
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802459}
parent ac6c324a
...@@ -9,6 +9,7 @@ import androidx.annotation.VisibleForTesting; ...@@ -9,6 +9,7 @@ import androidx.annotation.VisibleForTesting;
import org.chromium.base.Callback; import org.chromium.base.Callback;
import org.chromium.base.ThreadUtils; import org.chromium.base.ThreadUtils;
import org.chromium.base.TraceEvent;
import org.chromium.base.UserData; import org.chromium.base.UserData;
import org.chromium.base.UserDataHost; import org.chromium.base.UserDataHost;
import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.metrics.RecordHistogram;
...@@ -188,7 +189,10 @@ public abstract class PersistedTabData implements UserData { ...@@ -188,7 +189,10 @@ public abstract class PersistedTabData implements UserData {
abstract byte[] serialize(); abstract byte[] serialize();
private byte[] serializeAndLog() { private byte[] serializeAndLog() {
byte[] res = serialize(); byte[] res;
try (TraceEvent e = TraceEvent.scoped("PersistedTabData.Serialize")) {
res = serialize();
}
RecordHistogram.recordBooleanHistogram( RecordHistogram.recordBooleanHistogram(
"Tabs.PersistedTabData.Serialize." + getUmaTag(), res != null); "Tabs.PersistedTabData.Serialize." + getUmaTag(), res != null);
return res; return res;
...@@ -202,7 +206,10 @@ public abstract class PersistedTabData implements UserData { ...@@ -202,7 +206,10 @@ public abstract class PersistedTabData implements UserData {
abstract boolean deserialize(@Nullable byte[] bytes); abstract boolean deserialize(@Nullable byte[] bytes);
private void deserializeAndLog(@Nullable byte[] bytes) { private void deserializeAndLog(@Nullable byte[] bytes) {
boolean success = deserialize(bytes); boolean success;
try (TraceEvent e = TraceEvent.scoped("PersistedTabData.Deserialize")) {
success = deserialize(bytes);
}
RecordHistogram.recordBooleanHistogram( RecordHistogram.recordBooleanHistogram(
"Tabs.PersistedTabData.Deserialize." + getUmaTag(), success); "Tabs.PersistedTabData.Deserialize." + getUmaTag(), success);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment