Commit b3c39b52 authored by Dave Tapuska's avatar Dave Tapuska Committed by Chromium LUCI CQ

Remove some methods on CompositorDependencies that are uncalled.

These methods are uncalled via CompositorDependencies interface.

BUG=1097816

Change-Id: Id5d6ffd39246f6ff55b965c04c38a7e0403ab409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587372
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840296}
parent 14d063b3
...@@ -30,13 +30,9 @@ namespace content { ...@@ -30,13 +30,9 @@ namespace content {
class CONTENT_EXPORT CompositorDependencies { class CONTENT_EXPORT CompositorDependencies {
public: public:
virtual bool IsLcdTextEnabled() = 0;
virtual bool IsElasticOverscrollEnabled() = 0;
virtual bool IsUseZoomForDSFEnabled() = 0; virtual bool IsUseZoomForDSFEnabled() = 0;
virtual bool IsSingleThreaded() = 0;
virtual blink::scheduler::WebThreadScheduler* GetWebMainThreadScheduler() = 0; virtual blink::scheduler::WebThreadScheduler* GetWebMainThreadScheduler() = 0;
virtual cc::TaskGraphRunner* GetTaskGraphRunner() = 0; virtual cc::TaskGraphRunner* GetTaskGraphRunner() = 0;
virtual bool IsScrollAnimatorEnabled() = 0;
virtual std::unique_ptr<cc::UkmRecorderFactory> virtual std::unique_ptr<cc::UkmRecorderFactory>
CreateUkmRecorderFactory() = 0; CreateUkmRecorderFactory() = 0;
......
...@@ -1318,10 +1318,6 @@ RenderThreadImpl::GetCompositorMainThreadTaskRunner() { ...@@ -1318,10 +1318,6 @@ RenderThreadImpl::GetCompositorMainThreadTaskRunner() {
return main_thread_compositor_task_runner_; return main_thread_compositor_task_runner_;
} }
bool RenderThreadImpl::IsSingleThreaded() {
return !compositor_task_runner_;
}
gpu::GpuMemoryBufferManager* RenderThreadImpl::GetGpuMemoryBufferManager() { gpu::GpuMemoryBufferManager* RenderThreadImpl::GetGpuMemoryBufferManager() {
return gpu_->gpu_memory_buffer_manager(); return gpu_->gpu_memory_buffer_manager();
} }
......
...@@ -195,15 +195,15 @@ class CONTENT_EXPORT RenderThreadImpl ...@@ -195,15 +195,15 @@ class CONTENT_EXPORT RenderThreadImpl
scoped_refptr<base::SingleThreadTaskRunner> GetIOTaskRunner() override; scoped_refptr<base::SingleThreadTaskRunner> GetIOTaskRunner() override;
// CompositorDependencies implementation. // CompositorDependencies implementation.
bool IsLcdTextEnabled() override;
bool IsElasticOverscrollEnabled() override;
bool IsUseZoomForDSFEnabled() override; bool IsUseZoomForDSFEnabled() override;
bool IsSingleThreaded() override;
blink::scheduler::WebThreadScheduler* GetWebMainThreadScheduler() override; blink::scheduler::WebThreadScheduler* GetWebMainThreadScheduler() override;
cc::TaskGraphRunner* GetTaskGraphRunner() override; cc::TaskGraphRunner* GetTaskGraphRunner() override;
bool IsScrollAnimatorEnabled() override;
std::unique_ptr<cc::UkmRecorderFactory> CreateUkmRecorderFactory() override; std::unique_ptr<cc::UkmRecorderFactory> CreateUkmRecorderFactory() override;
bool IsLcdTextEnabled();
bool IsElasticOverscrollEnabled();
bool IsScrollAnimatorEnabled();
// TODO(crbug.com/1111231): The `enable_scroll_animator` flag is currently // TODO(crbug.com/1111231): The `enable_scroll_animator` flag is currently
// being passed as part of `CreateViewParams`, despite it looking like a // being passed as part of `CreateViewParams`, despite it looking like a
// global setting. It should probably be moved to some `mojom::Renderer` API // global setting. It should probably be moved to some `mojom::Renderer` API
......
...@@ -22,23 +22,10 @@ FakeCompositorDependencies::FakeCompositorDependencies() { ...@@ -22,23 +22,10 @@ FakeCompositorDependencies::FakeCompositorDependencies() {
FakeCompositorDependencies::~FakeCompositorDependencies() { FakeCompositorDependencies::~FakeCompositorDependencies() {
} }
bool FakeCompositorDependencies::IsLcdTextEnabled() {
return false;
}
bool FakeCompositorDependencies::IsElasticOverscrollEnabled() {
return true;
}
bool FakeCompositorDependencies::IsUseZoomForDSFEnabled() { bool FakeCompositorDependencies::IsUseZoomForDSFEnabled() {
return use_zoom_for_dsf_; return use_zoom_for_dsf_;
} }
bool FakeCompositorDependencies::IsSingleThreaded() {
// Currently never threaded compositing in unit tests.
return true;
}
blink::scheduler::WebThreadScheduler* blink::scheduler::WebThreadScheduler*
FakeCompositorDependencies::GetWebMainThreadScheduler() { FakeCompositorDependencies::GetWebMainThreadScheduler() {
return &main_thread_scheduler_; return &main_thread_scheduler_;
...@@ -48,10 +35,6 @@ cc::TaskGraphRunner* FakeCompositorDependencies::GetTaskGraphRunner() { ...@@ -48,10 +35,6 @@ cc::TaskGraphRunner* FakeCompositorDependencies::GetTaskGraphRunner() {
return &task_graph_runner_; return &task_graph_runner_;
} }
bool FakeCompositorDependencies::IsScrollAnimatorEnabled() {
return false;
}
std::unique_ptr<cc::UkmRecorderFactory> std::unique_ptr<cc::UkmRecorderFactory>
FakeCompositorDependencies::CreateUkmRecorderFactory() { FakeCompositorDependencies::CreateUkmRecorderFactory() {
return std::make_unique<cc::TestUkmRecorderFactory>(); return std::make_unique<cc::TestUkmRecorderFactory>();
......
...@@ -21,13 +21,9 @@ class FakeCompositorDependencies : public CompositorDependencies { ...@@ -21,13 +21,9 @@ class FakeCompositorDependencies : public CompositorDependencies {
~FakeCompositorDependencies() override; ~FakeCompositorDependencies() override;
// CompositorDependencies implementation. // CompositorDependencies implementation.
bool IsLcdTextEnabled() override;
bool IsElasticOverscrollEnabled() override;
bool IsUseZoomForDSFEnabled() override; bool IsUseZoomForDSFEnabled() override;
bool IsSingleThreaded() override;
blink::scheduler::WebThreadScheduler* GetWebMainThreadScheduler() override; blink::scheduler::WebThreadScheduler* GetWebMainThreadScheduler() override;
cc::TaskGraphRunner* GetTaskGraphRunner() override; cc::TaskGraphRunner* GetTaskGraphRunner() override;
bool IsScrollAnimatorEnabled() override;
std::unique_ptr<cc::UkmRecorderFactory> CreateUkmRecorderFactory() override; std::unique_ptr<cc::UkmRecorderFactory> CreateUkmRecorderFactory() override;
void set_use_zoom_for_dsf_enabled(bool enabled) { void set_use_zoom_for_dsf_enabled(bool enabled) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment