Commit b3ddfb4a authored by rdevlin.cronin's avatar rdevlin.cronin Committed by Commit bot

[Extensions Toolbar] Don't show the "show button" for hidden browser actions

Since browser actions that are hidden are now just overflowed to the wrench
menu, we don't really need the show button anymore.

BUG=453152

Review URL: https://codereview.chromium.org/879213005

Cr-Commit-Position: refs/heads/master@{#313645}
parent 094a1b40
...@@ -400,7 +400,11 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue( ...@@ -400,7 +400,11 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
else else
extension_data->SetInteger("order", 2); extension_data->SetInteger("order", 2);
if (!ExtensionActionAPI::GetBrowserActionVisibility(prefs, extension->id())) { // Don't show the "show button" for the browser action if the toolbar
// redesign is enabled, because "hidden" buttons are now just hidden in the
// wrench menu.
if (!ExtensionActionAPI::GetBrowserActionVisibility(prefs, extension->id()) &&
!FeatureSwitch::extension_action_redesign()->IsEnabled()) {
extension_data->SetBoolean("enable_show_button", true); extension_data->SetBoolean("enable_show_button", true);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment