Skip to content

GitLab

T
tangled
Commit b4060ea2 authored by Ella Ge's avatar Ella Ge Committed by Commit Bot
Browse files
Options

Remove unused CompositorThreadEventQueue histograms 

Remove
Event.CompositorThreadEventQueue.CoalescedCount
Event.CompositorThreadEventQueue.Continuous.HeadQueueingTime
Event.CompositorThreadEventQueue.Continuous.TailQueueingTime
Event.CompositorThreadEventQueue.NonContinuous.QueueingTime

Bug: 796006
Change-Id: Icc78eb8c6fbd47baeaaca5e1de50126744d9180e
Reviewed-on: https://chromium-review.googlesource.com/c/1392737Reviewed-by: default avatarNavid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619801}
parent c36327d0
Hide whitespace changes
Inline Side-by-side
Showing with 12 additions and 52 deletions
tools/metrics/histograms/histograms.xml
View file @ b4060ea2
......@@ -27274,6 +27274,9 @@ uploading your change for review.
<histogram name="Event.CompositorThreadEventQueue.CoalescedCount"
units="events">
<obsolete>
Deprecated 01/2019 due to lack of usage.
</obsolete>
<owner>eirage@chromium.org</owner>
<summary>
Number of continuous gesture events (GestureScrollUpdate,
......@@ -27287,6 +27290,9 @@ uploading your change for review.
<histogram name="Event.CompositorThreadEventQueue.Continuous.HeadQueueingTime"
units="microseconds">
<obsolete>
Deprecated 01/2019 due to lack of usage.
</obsolete>
<owner>eirage@chromium.org</owner>
<summary>
Time between the first event in a coalesced continuous gesture events group
......@@ -27305,6 +27311,9 @@ uploading your change for review.
<histogram name="Event.CompositorThreadEventQueue.Continuous.TailQueueingTime"
units="microseconds">
<obsolete>
Deprecated 01/2019 due to lack of usage.
</obsolete>
<owner>eirage@chromium.org</owner>
<summary>
Time between the last event in a coalesced continuous gesture events group
......@@ -27323,6 +27332,9 @@ uploading your change for review.
<histogram name="Event.CompositorThreadEventQueue.NonContinuous.QueueingTime"
units="microseconds">
<obsolete>
Deprecated 01/2019 due to lack of usage.
</obsolete>
<owner>eirage@chromium.org</owner>
<summary>
Time between when a non-continuous gesture event (GestureScrollStart/End,
ui/events/blink/input_handler_proxy.cc
View file @ b4060ea2
......@@ -43,8 +43,6 @@ namespace {
const int32_t kEventDispositionUndefined = -1;
const size_t kTenSeconds = 10 * 1000 * 1000;
cc::ScrollState CreateScrollStateForGesture(const WebGestureEvent& event) {
cc::ScrollStateData scroll_state_data;
switch (event.GetType()) {
......@@ -253,32 +251,6 @@ void InputHandlerProxy::HandleInputEventWithLatencyInfo(
void InputHandlerProxy::DispatchSingleInputEvent(
std::unique_ptr<EventWithCallback> event_with_callback,
const base::TimeTicks now) {
if (IsGestureScrollOrPinch(event_with_callback->event().GetType())) {
// Report the coalesced count only for continuous events to avoid the noise
// from non-continuous events.
if (IsContinuousGestureEvent(event_with_callback->event().GetType())) {
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Event.CompositorThreadEventQueue.Continuous.HeadQueueingTime",
(now - event_with_callback->creation_timestamp()).InMicroseconds(), 1,
kTenSeconds, 50);
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Event.CompositorThreadEventQueue.Continuous.TailQueueingTime",
(now - event_with_callback->last_coalesced_timestamp())
.InMicroseconds(),
1, kTenSeconds, 50);
UMA_HISTOGRAM_COUNTS_1000(
"Event.CompositorThreadEventQueue.CoalescedCount",
static_cast<int>(event_with_callback->coalesced_count()));
} else {
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Event.CompositorThreadEventQueue.NonContinuous.QueueingTime",
(now - event_with_callback->creation_timestamp()).InMicroseconds(), 1,
kTenSeconds, 50);
}
}
ui::LatencyInfo monitored_latency_info = event_with_callback->latency_info();
std::unique_ptr<cc::SwapPromiseMonitor> latency_info_swap_promise_monitor =
input_handler_->CreateLatencyInfoSwapPromiseMonitor(
......
ui/events/blink/input_handler_proxy_unittest.cc
View file @ b4060ea2
......@@ -49,15 +49,6 @@ namespace test {
namespace {
const char* kCoalescedCountHistogram =
"Event.CompositorThreadEventQueue.CoalescedCount";
const char* kContinuousHeadQueueingTimeHistogram =
"Event.CompositorThreadEventQueue.Continuous.HeadQueueingTime";
const char* kContinuousTailQueueingTimeHistogram =
"Event.CompositorThreadEventQueue.Continuous.TailQueueingTime";
const char* kNonContinuousQueueingTimeHistogram =
"Event.CompositorThreadEventQueue.NonContinuous.QueueingTime";
enum InputHandlerProxyTestType {
ROOT_SCROLL_NORMAL_HANDLER,
ROOT_SCROLL_SYNCHRONOUS_HANDLER,
......@@ -1406,8 +1397,6 @@ TEST(SynchronousInputHandlerProxyTest, SetOffset) {
}
TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedGestureScroll) {
base::HistogramTester histogram_tester;
// Handle scroll on compositor.
cc::InputHandlerScrollResult scroll_result_did_scroll_;
scroll_result_did_scroll_.did_scroll = true;
......@@ -1465,12 +1454,9 @@ TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedGestureScroll) {
EXPECT_EQ(InputHandlerProxy::DID_HANDLE, event_disposition_recorder_[2]);
EXPECT_EQ(InputHandlerProxy::DID_HANDLE, event_disposition_recorder_[3]);
testing::Mock::VerifyAndClearExpectations(&mock_input_handler_);
histogram_tester.ExpectUniqueSample(kCoalescedCountHistogram, 2, 1);
}
TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedGestureScrollPinchScroll) {
base::HistogramTester histogram_tester;
// Handle scroll on compositor.
cc::InputHandlerScrollResult scroll_result_did_scroll_;
scroll_result_did_scroll_.did_scroll = true;
......@@ -1530,12 +1516,9 @@ TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedGestureScrollPinchScroll) {
EXPECT_EQ(0ul, event_queue().size());
EXPECT_EQ(12ul, event_disposition_recorder_.size());
testing::Mock::VerifyAndClearExpectations(&mock_input_handler_);
histogram_tester.ExpectBucketCount(kCoalescedCountHistogram, 1, 2);
histogram_tester.ExpectBucketCount(kCoalescedCountHistogram, 2, 2);
}
TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedQueueingTime) {
base::HistogramTester histogram_tester;
base::SimpleTestTickClock tick_clock;
tick_clock.SetNowTicks(base::TimeTicks::Now());
SetInputHandlerProxyTickClockForTesting(&tick_clock);
......@@ -1569,13 +1552,6 @@ TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedQueueingTime) {
EXPECT_EQ(0ul, event_queue().size());
EXPECT_EQ(5ul, event_disposition_recorder_.size());
testing::Mock::VerifyAndClearExpectations(&mock_input_handler_);
histogram_tester.ExpectUniqueSample(kContinuousHeadQueueingTimeHistogram, 140,
1);
histogram_tester.ExpectUniqueSample(kContinuousTailQueueingTimeHistogram, 80,
1);
histogram_tester.ExpectBucketCount(kNonContinuousQueueingTimeHistogram, 0, 1);
histogram_tester.ExpectBucketCount(kNonContinuousQueueingTimeHistogram, 70,
1);
}
TEST_F(InputHandlerProxyEventQueueTest, VSyncAlignedCoalesceScrollAndPinch) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment