Commit b40adc51 authored by Caleb Raitto's avatar Caleb Raitto Committed by Commit Bot

Disable leaking blink_platform_unittests on LSAN.

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 960984
Change-Id: I37833956b7c9fd6b82a04a264dcaac096aebdd81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638779Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666448}
parent 8f2fffbe
......@@ -16,6 +16,15 @@
#include "third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h"
#include "third_party/blink/renderer/platform/wtf/functional.h"
// TODO(crbug.com/960984): Fix memory leaks in tests and re-enable on LSAN.
#ifdef LEAK_SANITIZER
#define MAYBE_PausableTasks DISABLED_PausableTasks
#define MAYBE_NestedPauseHandlesTasks DISABLED_NestedPauseHandlesTasks
#else
#define MAYBE_PausableTasks PausableTasks
#define MAYBE_NestedPauseHandlesTasks NestedPauseHandlesTasks
#endif
using testing::ElementsAre;
using testing::ElementsAreArray;
......@@ -272,7 +281,7 @@ TEST_F(WorkerSchedulerTest,
base::TimeTicks() + base::TimeDelta::FromSeconds(41)));
}
TEST_F(WorkerSchedulerTest, PausableTasks) {
TEST_F(WorkerSchedulerTest, MAYBE_PausableTasks) {
std::vector<std::string> run_order;
auto pause_handle = worker_scheduler_->Pause();
// Tests interlacing pausable, throttable and unpausable tasks and
......@@ -291,7 +300,7 @@ TEST_F(WorkerSchedulerTest, PausableTasks) {
EXPECT_THAT(run_order, testing::ElementsAre("T3", "T1", "T2"));
}
TEST_F(WorkerSchedulerTest, NestedPauseHandlesTasks) {
TEST_F(WorkerSchedulerTest, MAYBE_NestedPauseHandlesTasks) {
std::vector<std::string> run_order;
auto pause_handle = worker_scheduler_->Pause();
{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment