Commit b424ebc2 authored by Viet-Trung Luu's avatar Viet-Trung Luu

Update virtual/final usage in url/.

BUG=417463
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/658563010

Cr-Commit-Position: refs/heads/master@{#300620}
parent b9cc2b26
...@@ -24,11 +24,11 @@ class URL_EXPORT ICUCharsetConverter : public CharsetConverter { ...@@ -24,11 +24,11 @@ class URL_EXPORT ICUCharsetConverter : public CharsetConverter {
// be managed by the creator such that it is alive as long as this is. // be managed by the creator such that it is alive as long as this is.
ICUCharsetConverter(UConverter* converter); ICUCharsetConverter(UConverter* converter);
virtual ~ICUCharsetConverter(); ~ICUCharsetConverter() override;
virtual void ConvertFromUTF16(const base::char16* input, void ConvertFromUTF16(const base::char16* input,
int input_len, int input_len,
CanonOutput* output) override; CanonOutput* output) override;
private: private:
// The ICU converter, not owned by this class. // The ICU converter, not owned by this class.
......
...@@ -36,12 +36,12 @@ namespace url { ...@@ -36,12 +36,12 @@ namespace url {
class URL_EXPORT StdStringCanonOutput : public CanonOutput { class URL_EXPORT StdStringCanonOutput : public CanonOutput {
public: public:
StdStringCanonOutput(std::string* str); StdStringCanonOutput(std::string* str);
virtual ~StdStringCanonOutput(); ~StdStringCanonOutput() override;
// Must be called after writing has completed but before the string is used. // Must be called after writing has completed but before the string is used.
void Complete(); void Complete();
virtual void Resize(int sz) override; void Resize(int sz) override;
protected: protected:
std::string* str_; std::string* str_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment