getElementsByClassName should include non styled Elements

Allow Elements who are not styled but have class set to be retrieved using getElementsByClassName. Matches FF behavior. https://bugs.webkit.org/show_bug.cgi?id=94718 Review URL: https://codereview.chromium.org/458663003 git-svn-id: svn://svn.chromium.org/blink/trunk@180414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

getElementsByClassName should include non styled Elements
Allow Elements who are not styled but have class set to be retrieved using getElementsByClassName. Matches FF behavior. https://bugs.webkit.org/show_bug.cgi?id=94718 Review URL: https://codereview.chromium.org/458663003 git-svn-id: svn://svn.chromium.org/blink/trunk@180414 bbb929c8-8fbe-4397-9dbb-9b2b20218538
b42e8076 · rob.buis@samsung.com · 8d4e7f36 · b42e8076 · b42e8076 · b42e8076
Commit b42e8076 authored Aug 17, 2014 by rob.buis@samsung.com
4 changed files
--- a/third_party/WebKit/LayoutTests/fast/dom/getElementsByClassName/011.xml
+++ b/third_party/WebKit/LayoutTests/fast/dom/getElementsByClassName/011.xml
@@ -12,8 +12,8 @@
  <t:x class="a" t:class="a" h:class="a" g:class="a"/>
  <script>
   var collection = document.getElementsByClassName("a"),
-       test = document.getElementsByTagName("x")
-   t(collection, [test[0], test[1]])
+       test = document.getElementsByTagNameNS("*", "x")
+   t(collection, [test[0], test[1], test[4]])
  </script>
 </body>
 </html>
--- a/third_party/WebKit/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt
+++ b/third_party/WebKit/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt
+This test checks to see if getElementsByClassName finds non styled elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.getElementsByClassName('target').length is 2
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
--- a/third_party/WebKit/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html
+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../../resources/js-test.js"></script>
+</head>
+<body>
+<script type="text/javascript">
+description("This test checks to see if getElementsByClassName finds non styled elements.");
+
+var d = document.createElement("div");
+d.setAttribute("class", "target");
+document.documentElement.appendChild(d);
+
+var e = document.createElementNS("http://foo.com", "div");
+e.setAttribute("class", "target");
+document.documentElement.appendChild(e);
+
+shouldBe("document.getElementsByClassName('target').length", "2");
+</script>
+</body>
+</html>
--- a/third_party/WebKit/Source/core/dom/ClassCollection.h
+++ b/third_party/WebKit/Source/core/dom/ClassCollection.h
@@ -65,10 +65,6 @@ inline bool ClassCollection::elementMatches(const Element& testElement) const
        return false;
    if (!m_classNames.size())
        return false;
-    // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
-    // https://bugs.webkit.org/show_bug.cgi?id=94718
-    if (!testElement.isStyledElement())
-        return false;
    return testElement.classNames().containsAll(m_classNames);
 }