Skip to content

GitLab

T
tangled
Commit b440e0a2 authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot
Browse files
Options

Update tests for forced breaks at fragmentainer start. 

If there's a forced break, and it's at a valid class A breakpoint, we
may break there. There's nothing in the spec suggesting otherwise.

This is working correctly in the LayoutNG fragmentation engine, but not
in the legacy engine (where we require some non-zero block-size content
to allow forced breaks). Remove invalid tests, and add a couple of valid
ones.

Bug: 1100849
Change-Id: I1829a00a4e9761906ebe4536ded9c994f4737e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339663Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarAlison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795604}
parent 7a698164
Hide whitespace changes
Inline Side-by-side
Showing with 25 additions and 41 deletions
third_party/blink/web_tests/TestExpectations
View file @ b440e0a2
......@@ -1013,6 +1013,7 @@ crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/break-b
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/break-between-avoid-003.html [ Pass ]
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/break-between-avoid-004.html [ Pass ]
crbug.com/1028595 virtual/layout_ng_block_frag/external/wpt/css/css-break/fieldset-001.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/forced-break-at-fragmentainer-start-000.html [ Pass ]
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/overflowed-block-with-no-room-after-001.html [ Pass ]
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/overflowed-block-with-no-room-after-000.html [ Pass ]
crbug.com/829028 virtual/layout_ng_block_frag/external/wpt/css/css-break/tall-line-in-short-fragmentainer-000.html [ Pass ]
......@@ -1131,8 +1132,6 @@ crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/float-with-margin-mo
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/float-with-margin-moved-by-child-block.html [ Failure Timeout ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/float-with-margin-moved-by-child-line-and-unbreakable.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fast/multicol/float-with-margin-moved-by-child-line.html [ Failure ]
crbug.com/1100849 virtual/layout_ng_block_frag/fast/multicol/forced-break-after-block-with-spanner.html [ Failure ]
crbug.com/591099 virtual/layout_ng_block_frag/fast/multicol/forced-break-after-empty-block-after-spanner.html [ Failure ]
crbug.com/591099 virtual/layout_ng_block_frag/fast/multicol/forced-break-in-nested-columns.html [ Failure ]
crbug.com/591099 virtual/layout_ng_block_frag/fast/multicol/forced-break-too-short-column.html [ Failure ]
crbug.com/591099 virtual/layout_ng_block_frag/fast/multicol/hit-test-above-or-below.html [ Failure ]
......@@ -3562,6 +3561,7 @@ crbug.com/829028 external/wpt/css/css-break/break-between-avoid-000.html [ Failu
crbug.com/829028 external/wpt/css/css-break/break-between-avoid-001.html [ Failure ]
crbug.com/829028 external/wpt/css/css-break/break-between-avoid-003.html [ Failure ]
crbug.com/829028 external/wpt/css/css-break/break-between-avoid-004.html [ Failure ]
crbug.com/829028 external/wpt/css/css-break/forced-break-at-fragmentainer-start-000.html [ Failure ]
crbug.com/829028 external/wpt/css/css-break/overflowed-block-with-no-room-after-001.html [ Failure ]
crbug.com/829028 external/wpt/css/css-break/overflowed-block-with-no-room-after-000.html [ Failure ]
crbug.com/829028 external/wpt/css/css-break/tall-line-in-short-fragmentainer-000.html [ Failure ]
......
third_party/blink/web_tests/external/wpt/css/css-break/forced-break-at-fragmentainer-start-000.html 0 → 100644
View file @ b440e0a2
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#forced-breaks">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#unforced-breaks">
<meta name="assert" content="A forced break at the block-start of the fragmentainer is allowed, as long as it's otherwise at a valid class A break point">
<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
<p>Test passes if there is a filled green square.</p>
<div style="columns:1; column-fill:auto; width:100px; height:100px; background:green;">
<div style="break-after:column;"></div>
<div style="height:99px; background:white;"></div>
</div>
third_party/blink/web_tests/external/wpt/css/css-break/forced-break-at-fragmentainer-start-001.html 0 → 100644
View file @ b440e0a2
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#forced-breaks">
<link rel="help" href="https://www.w3.org/TR/css-break-3/#unforced-breaks">
<meta name="assert" content="A forced break at the block-start of the fragmentainer is not allowed unless it's at a valid class A break point">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:2; column-fill:auto; column-gap:0; width:100px; height:100px; background:red;">
<div>
<div style="break-before:column; height:200px; background:green;"></div>
</div>
</div>
third_party/blink/web_tests/fast/multicol/forced-break-after-block-with-spanner-expected.html deleted 100644 → 0
View file @ 7a698164
<!DOCTYPE html>
<p>There should be a hotpink square below.</p>
<div style="height:50px;"></div>
<div style="width:50px; height:50px; background:hotpink;"></div>
third_party/blink/web_tests/fast/multicol/forced-break-after-block-with-spanner.html deleted 100644 → 0
View file @ 7a698164
<!DOCTYPE html>
<style>
.block { width:50px; height:25px; break-inside:avoid; }
</style>
<p>There should be a hotpink square below.</p>
<div style="columns:2;">
<div style="break-after:column;">
<div class="block"></div>
<div class="block"></div>
<div class="block" style="background:hotpink;"></div>
<div class="block"></div>
<div class="block"></div>
<div style="column-span:all;"></div>
</div>
<div class="block" style="background:hotpink;"></div>
</div>
third_party/blink/web_tests/fast/multicol/forced-break-after-empty-block-after-spanner-expected.html deleted 100644 → 0
View file @ 7a698164
<!DOCTYPE html>
<p>There should be a hotpink square below.</p>
<div style="height:50px;"></div>
<div style="width:50px; height:50px; background:hotpink;"></div>
third_party/blink/web_tests/fast/multicol/forced-break-after-empty-block-after-spanner.html deleted 100644 → 0
View file @ 7a698164
<!DOCTYPE html>
<style>
.block { width:50px; height:25px; break-inside:avoid; }
</style>
<p>There should be a hotpink square below.</p>
<div style="columns:2;">
<div class="block"></div>
<div class="block"></div>
<div class="block" style="background:hotpink;"></div>
<div class="block"></div>
<div class="block"></div>
<div style="column-span:all;"></div>
<div style="break-after:column;"></div>
<div class="block" style="background:hotpink;"></div>
</div>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment