Skip to content

GitLab

T
tangled
Commit b458e958 authored by François Beaufort's avatar François Beaufort Committed by Commit Bot
Browse files
Options

[Picture-in-Picture] Remove Origin Trial. 

Picture-in-Picture Origin Trial has been cancelled due to multiple risk
factors incl. surface layer memory regressions which require
investigating, as well as PiP related issues (crashes, resizing, etc.).

Bug: 806249
Change-Id: I35d06042e949b6e931e16799ca7abb6f0ff36bfa
Reviewed-on: https://chromium-review.googlesource.com/1084451Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#564832}
parent b15094a6
Hide whitespace changes
Inline Side-by-side
Showing with 13 additions and 34 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ b458e958
......@@ -4651,9 +4651,6 @@ crbug.com/811977 virtual/video-surface-layer/media/picture-in-picture/picture-in
crbug.com/806249 virtual/video-surface-layer/media/picture-in-picture/controls/picture-in-picture-button.html [ Failure ]
crbug.com/806249 virtual/video-surface-layer/media/picture-in-picture/controls/picture-in-picture-video-with-audio-only-button.html [ Failure ]
# TODO(fbeaufort) Remove when Picture-in-Picture Origin Trial for Desktop ends.
crbug.com/806249 [ Android ] virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/picture-in-picture-api-origin-trial-interfaces.html [ Failure ]
# Sheriff 2018-02-26
crbug.com/816475 [ Win7 Linux ] external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html [ Failure Pass ]
crbug.com/816914 [ Mac ] fast/canvas/canvas-drawImage-live-video.html [ Failure Pass ]
......
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/picture-in-picture-api-origin-trial-interfaces.html deleted 100644 → 0
View file @ b15094a6
<!DOCTYPE html>
<meta charset="utf-8">
<!-- Generate token with the command:
generate_token.py http://127.0.0.1:8000 PictureInPictureAPI --expire-timestamp=2000000000
-- -->
<meta http-equiv="origin-trial" content="AnMoDHlV+HvtwZWfMIUkSky4JXkziEsX/it6PNmHxLnBW+Tz5xAPQVyZTb527gXY2yW53m1ylzeSPXAUnDyJPAUAAABbeyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR1cmUiOiAiUGljdHVyZUluUGljdHVyZUFQSSIsICJleHBpcnkiOiAyMDAwMDAwMDAwfQ==" />
<title>Picture-in-Picture API - interfaces and properties exposed by origin trial</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/origin-trials-helper.js"></script>
<script>
test(t => {
OriginTrialsHelper.check_properties(this,
{'PictureInPictureWindow': ['width', 'height', 'onresize'],
'Document': ['pictureInPictureEnabled', 'pictureInPictureElement', 'exitPictureInPicture'],
'HTMLVideoElement': ['requestPictureInPicture', 'disablePictureInPicture', 'onenterpictureinpicture', 'onleavepictureinpicture']
});
}, 'Picture-in-Picture API interfaces and properties in Origin-Trial enabled document.');
</script>
third_party/blink/renderer/modules/picture_in_picture/document_picture_in_picture.idl
View file @ b458e958
......@@ -6,7 +6,7 @@
// https://wicg.github.io/picture-in-picture/#documentorshadowroot-extension
[
ImplementedAs=DocumentPictureInPicture,
OriginTrialEnabled=PictureInPictureAPI
RuntimeEnabled=PictureInPictureAPI
]
partial interface Document {
[Measure] readonly attribute boolean pictureInPictureEnabled;
......@@ -15,4 +15,4 @@ partial interface Document {
// TODO(crbug.com/656517): Define this attribute in DocumentOrShadowRoot.
[Measure] readonly attribute HTMLVideoElement? pictureInPictureElement;
};
\ No newline at end of file
};
third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.idl
View file @ b458e958
......@@ -5,7 +5,7 @@
// https://wicg.github.io/picture-in-picture/#htmlvideoelement-extensions
[
ImplementedAs=HTMLVideoElementPictureInPicture,
OriginTrialEnabled=PictureInPictureAPI
RuntimeEnabled=PictureInPictureAPI
]
partial interface HTMLVideoElement {
[CallWith=ScriptState, Measure] Promise<PictureInPictureWindow> requestPictureInPicture();
......@@ -15,4 +15,4 @@ partial interface HTMLVideoElement {
[CEReactions, Measure, Reflect] attribute boolean disablePictureInPicture;
};
\ No newline at end of file
};
third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_window.idl
View file @ b458e958
......@@ -5,7 +5,7 @@
// https://wicg.github.io/picture-in-picture/#interface-picture-in-picture-window
[
ActiveScriptWrappable,
OriginTrialEnabled=PictureInPictureAPI
RuntimeEnabled=PictureInPictureAPI
]
interface PictureInPictureWindow : EventTarget {
[Measure] readonly attribute long width;
......
third_party/blink/renderer/modules/picture_in_picture/shadow_root_picture_in_picture.idl
View file @ b458e958
......@@ -5,9 +5,9 @@
// https://wicg.github.io/picture-in-picture/#documentorshadowroot-extension
[
ImplementedAs=ShadowRootPictureInPicture,
OriginTrialEnabled=PictureInPictureAPI
RuntimeEnabled=PictureInPictureAPI
]
partial interface ShadowRoot {
// TODO(crbug.com/656517): Define this attribute in DocumentOrShadowRoot.
[Measure] readonly attribute HTMLVideoElement? pictureInPictureElement;
};
\ No newline at end of file
};
third_party/blink/renderer/platform/feature_policy/feature_policy.cc
View file @ b458e958
......@@ -145,9 +145,10 @@ bool IsSupportedInFeaturePolicy(mojom::FeaturePolicyFeature feature) {
case mojom::FeaturePolicyFeature::kAmbientLightSensor:
case mojom::FeaturePolicyFeature::kGyroscope:
case mojom::FeaturePolicyFeature::kMagnetometer:
case mojom::FeaturePolicyFeature::kPictureInPicture:
case mojom::FeaturePolicyFeature::kSyncXHR:
return true;
case mojom::FeaturePolicyFeature::kPictureInPicture:
return RuntimeEnabledFeatures::PictureInPictureAPIEnabled();
case mojom::FeaturePolicyFeature::kUnsizedMedia:
case mojom::FeaturePolicyFeature::kVerticalScroll:
case mojom::FeaturePolicyFeature::kLegacyImageFormats:
......@@ -192,8 +193,10 @@ const FeatureNameMap& GetDefaultFeatureNameMap() {
mojom::FeaturePolicyFeature::kGyroscope);
default_feature_name_map.Set("magnetometer",
mojom::FeaturePolicyFeature::kMagnetometer);
default_feature_name_map.Set("picture-in-picture",
mojom::FeaturePolicyFeature::kPictureInPicture);
if (RuntimeEnabledFeatures::PictureInPictureAPIEnabled()) {
default_feature_name_map.Set(
"picture-in-picture", mojom::FeaturePolicyFeature::kPictureInPicture);
}
if (RuntimeEnabledFeatures::ExperimentalProductivityFeaturesEnabled()) {
default_feature_name_map.Set(
"document-stream-insertion",
......
third_party/blink/renderer/platform/runtime_enabled_features.json5
View file @ b458e958
......@@ -956,8 +956,6 @@
},
{
name: "PictureInPictureAPI",
origin_trial_feature_name: "PictureInPictureAPI",
origin_trial_os: ["chromeos", "linux", "macosx", "win"],
status: "experimental",
},
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment