Commit b475724c authored by Ian Barkley-Yeung's avatar Ian Barkley-Yeung Committed by Commit Bot

Feedback window: Minor accessibility improvements

Add the AIRA role of "alert" to the "selected file is too big" error
message. This should convince screen readers to announce the error. It's
time sensitive (per aira "alert" role guidelines) because if the user
presses "Send" before hearing the alert, they won't know the file wasn't
sent. Not perfect (if the user chooses another file that is too big, the
error is not re-announced), but better than what we have currently.

Also add aira-describedby to the attach file window, so that the screen
readers treat "File will be sent to Google for debugging" as an extra
description of the field.

BUG=chromium:1005559, chromium:1005528
TEST=ChromeVox on ChromeOS. "Selected file is too big" was announced
after selecting a large file. (Took a long time, but it was announced).
"File will be sent to Google for debugging" was spoken after "Attach
file No file chosen".

R=afakhry@chromium.org

Change-Id: Ic60b811cd1902e6e621048ed6e9ab6da838ba267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863363Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706282}
parent 026bd8f3
......@@ -47,13 +47,14 @@
<!-- Attach a file -->
<div id="attach-file-container" class="text-field-container">
<label id="attach-file-label" i18n-content="attach-file-label"></label>
<input id="attach-file" type="file" aria-labelledby="attach-file-label">
<input id="attach-file" type="file" aria-labelledby="attach-file-label"
aria-describedby="attach-file-note">
<div id="custom-file-container" hidden>
<label id="attached-filename-text"></label>
<button id="remove-attached-file" class="remove-file-button"></button>
</div>
<div id="attach-error" class="attach-file-notification"
i18n-content="attach-file-to-big" hidden></div>
role="alert" i18n-content="attach-file-to-big" hidden></div>
</div>
<div id="attach-file-note" i18n-content="attach-file-note"></div>
<!-- Screenshot -->
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment