Add about flags for pseudo-USS datatypes

Each flag maps to one feature toggle representing one (usually) or two
(rarely) sync datatypes.

If enabled, the sync datatype(s) are wrapped within the USS
architecture, based on the so-called pseudo-USS approach
(SyncableServiceBasedBridge).

The functionality has been sanity-checked for crashes on dev&canary
already, although some resulting UMA is suspicious. The flags should
allow easier debugging and testing.

Bug: 870624
Change-Id: Id5762c01f7232de8dda4e524083fae59f66217a2
Reviewed-on: https://chromium-review.googlesource.com/c/1329142
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606991}

chrome/browser/about_flags.cc

@@ -4012,6 +4012,59 @@ const FeatureEntry kFeatureEntries[] = {
     {"single-click-autofill", flag_descriptions::kSingleClickAutofillName,
      flag_descriptions::kSingleClickAutofillDescription, kOsAll,
      FEATURE_VALUE_TYPE(autofill::features::kSingleClickAutofill)},
+    {"enable-sync-pseudo-uss-app-list",
+     flag_descriptions::kEnableSyncPseudoUSSAppListName,
+     flag_descriptions::kEnableSyncPseudoUSSAppListDescription, kOsCrOS,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSAppList)},
+    {"enable-sync-pseudo-uss-apps",
+     flag_descriptions::kEnableSyncPseudoUSSAppsName,
+     flag_descriptions::kEnableSyncPseudoUSSAppsDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSApps)},
+    {"enable-sync-pseudo-uss-dictionary",
+     flag_descriptions::kEnableSyncPseudoUSSDictionaryName,
+     flag_descriptions::kEnableSyncPseudoUSSDictionaryDescription,
+     kOsWin | kOsLinux, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSDictionary)},
+    {"enable-sync-pseudo-uss-extension-settings",
+     flag_descriptions::kEnableSyncPseudoUSSExtensionSettingsName,
+     flag_descriptions::kEnableSyncPseudoUSSExtensionSettingsDescription,
+     kOsDesktop, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSExtensionSettings)},
+    {"enable-sync-pseudo-uss-extensions",
+     flag_descriptions::kEnableSyncPseudoUSSExtensionsName,
+     flag_descriptions::kEnableSyncPseudoUSSExtensionsDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSExtensions)},
+    {"enable-sync-pseudo-uss-favicons",
+     flag_descriptions::kEnableSyncPseudoUSSFaviconsName,
+     flag_descriptions::kEnableSyncPseudoUSSFaviconsDescription, kOsAll,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSFavicons)},
+    {"enable-sync-pseudo-uss-history-delete-directives",
+     flag_descriptions::kEnableSyncPseudoUSSHistoryDeleteDirectivesName,
+     flag_descriptions::kEnableSyncPseudoUSSHistoryDeleteDirectivesDescription,
+     kOsAll,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSHistoryDeleteDirectives)},
+    {"enable-sync-pseudo-uss-passwords",
+     flag_descriptions::kEnableSyncPseudoUSSPasswordsName,
+     flag_descriptions::kEnableSyncPseudoUSSPasswordsDescription, kOsAll,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPasswords)},
+    {"enable-sync-pseudo-uss-preferences",
+     flag_descriptions::kEnableSyncPseudoUSSPreferencesName,
+     flag_descriptions::kEnableSyncPseudoUSSPreferencesDescription, kOsAll,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPreferences)},
+    {"enable-sync-pseudo-uss-priority-preferences",
+     flag_descriptions::kEnableSyncPseudoUSSPriorityPreferencesName,
+     flag_descriptions::kEnableSyncPseudoUSSPriorityPreferencesDescription,
+     kOsAll, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSPriorityPreferences)},
+    {"enable-sync-pseudo-uss-search-engines",
+     flag_descriptions::kEnableSyncPseudoUSSSearchEnginesName,
+     flag_descriptions::kEnableSyncPseudoUSSSearchEnginesDescription,
+     kOsDesktop, FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSSearchEngines)},
+    {"enable-sync-pseudo-uss-supervised-users",
+     flag_descriptions::kEnableSyncPseudoUSSSupervisedUsersName,
+     flag_descriptions::kEnableSyncPseudoUSSSupervisedUsersDescription, kOsAll,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSSupervisedUsers)},
+    {"enable-sync-pseudo-uss-themes",
+     flag_descriptions::kEnableSyncPseudoUSSThemesName,
+     flag_descriptions::kEnableSyncPseudoUSSThemesDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(switches::kSyncPseudoUSSThemes)},
     {"enable-sync-user-consent-separate-type",
      flag_descriptions::kEnableSyncUserConsentSeparateTypeName,
      flag_descriptions::kEnableSyncUserConsentSeparateTypeDescription, kOsAll,

chrome/browser/flag_descriptions.cc

@@ -807,6 +807,74 @@ const char kEnableResourceLoadingHintsDescription[] =
     "Enable using server-provided resource loading hints to provide a preview "
     "over slow network connections.";
 
+const char kEnableSyncPseudoUSSAppListName[] =
+    "Enable pseudo-USS for APP_LIST sync.";
+const char kEnableSyncPseudoUSSAppListDescription[] =
+    "Enable new USS-based codepath for sync datatype APP_LIST.";
+
+const char kEnableSyncPseudoUSSAppsName[] = "Enable pseudo-USS for APPS sync.";
+const char kEnableSyncPseudoUSSAppsDescription[] =
+    "Enable new USS-based codepath for sync datatype APPS.";
+
+const char kEnableSyncPseudoUSSDictionaryName[] =
+    "Enable pseudo-USS for DICTIONARY sync.";
+const char kEnableSyncPseudoUSSDictionaryDescription[] =
+    "Enable new USS-based codepath for sync datatype DICTIONARY.";
+
+const char kEnableSyncPseudoUSSExtensionSettingsName[] =
+    "Enable pseudo-USS for EXTENSION_SETTINGS and APP_SETTINGS sync.";
+const char kEnableSyncPseudoUSSExtensionSettingsDescription[] =
+    "Enable new USS-based codepath for sync datatypes EXTENSION_SETTINGS and "
+    "APP_SETTINGS.";
+
+const char kEnableSyncPseudoUSSExtensionsName[] =
+    "Enable pseudo-USS for EXTENSIONS sync.";
+const char kEnableSyncPseudoUSSExtensionsDescription[] =
+    "Enable new USS-based codepath for sync datatype EXTENSIONS.";
+
+const char kEnableSyncPseudoUSSFaviconsName[] =
+    "Enable pseudo-USS for favicon sync.";
+const char kEnableSyncPseudoUSSFaviconsDescription[] =
+    "Enable new USS-based codepath for sync datatypes FAVICON_IMAGES and "
+    "FAVICON_TRACKING.";
+
+const char kEnableSyncPseudoUSSHistoryDeleteDirectivesName[] =
+    "Enable pseudo-USS for HISTORY_DELETE_DIRECTIVES sync.";
+const char kEnableSyncPseudoUSSHistoryDeleteDirectivesDescription[] =
+    "Enable new USS-based codepath for sync datatype "
+    "HISTORY_DELETE_DIRECTIVES.";
+
+const char kEnableSyncPseudoUSSPasswordsName[] =
+    "Enable pseudo-USS for PASSWORDS sync.";
+const char kEnableSyncPseudoUSSPasswordsDescription[] =
+    "Enable new USS-based codepath for sync datatype PASSWORDS (pseudo-USS).";
+
+const char kEnableSyncPseudoUSSPreferencesName[] =
+    "Enable pseudo-USS for PREFERENCES sync.";
+const char kEnableSyncPseudoUSSPreferencesDescription[] =
+    "Enable new USS-based codepath for sync datatype PREFERENCES.";
+
+const char kEnableSyncPseudoUSSPriorityPreferencesName[] =
+    "Enable pseudo-USS for PRIORITY_PREFERENCES sync.";
+const char kEnableSyncPseudoUSSPriorityPreferencesDescription[] =
+    "Enable new USS-based codepath for sync datatype PRIORITY_PREFERENCES.";
+
+const char kEnableSyncPseudoUSSSearchEnginesName[] =
+    "Enable pseudo-USS for SEARCH_ENGINES sync.";
+const char kEnableSyncPseudoUSSSearchEnginesDescription[] =
+    "Enable new USS-based codepath for sync datatype SEARCH_ENGINES.";
+
+const char kEnableSyncPseudoUSSSupervisedUsersName[] =
+    "Enable pseudo-USS for supervised users sync.";
+const char kEnableSyncPseudoUSSSupervisedUsersDescription[] =
+    "Enable new USS-based codepath for sync datatypes SUPERVISED_USER_SETTINGS "
+    "and SUPERVISED_USER_WHITELISTS.";
+
+const char kEnableSyncPseudoUSSThemesName[] =
+    "Enable pseudo-USS for THEMES sync.";
+const char kEnableSyncPseudoUSSThemesDescription[] =
+    "Enable new USS-based codepath for sync datatype THEMES.";
+
 const char kEnableSyncUserConsentSeparateTypeName[] =
     "Enable separate sync type for consents";
 const char kEnableSyncUserConsentSeparateTypeDescription[] =

chrome/browser/flag_descriptions.h

@@ -496,6 +496,45 @@ extern const char kEnableResamplingScrollEventsDescription[];
 extern const char kEnableResourceLoadingHintsName[];
 extern const char kEnableResourceLoadingHintsDescription[];
 
+extern const char kEnableSyncPseudoUSSAppListName[];
+extern const char kEnableSyncPseudoUSSAppListDescription[];
+
+extern const char kEnableSyncPseudoUSSAppsName[];
+extern const char kEnableSyncPseudoUSSAppsDescription[];
+
+extern const char kEnableSyncPseudoUSSDictionaryName[];
+extern const char kEnableSyncPseudoUSSDictionaryDescription[];
+
+extern const char kEnableSyncPseudoUSSExtensionSettingsName[];
+extern const char kEnableSyncPseudoUSSExtensionSettingsDescription[];
+
+extern const char kEnableSyncPseudoUSSExtensionsName[];
+extern const char kEnableSyncPseudoUSSExtensionsDescription[];
+
+extern const char kEnableSyncPseudoUSSFaviconsName[];
+extern const char kEnableSyncPseudoUSSFaviconsDescription[];
+
+extern const char kEnableSyncPseudoUSSHistoryDeleteDirectivesName[];
+extern const char kEnableSyncPseudoUSSHistoryDeleteDirectivesDescription[];
+
+extern const char kEnableSyncPseudoUSSPasswordsName[];
+extern const char kEnableSyncPseudoUSSPasswordsDescription[];
+
+extern const char kEnableSyncPseudoUSSPreferencesName[];
+extern const char kEnableSyncPseudoUSSPreferencesDescription[];
+
+extern const char kEnableSyncPseudoUSSPriorityPreferencesName[];
+extern const char kEnableSyncPseudoUSSPriorityPreferencesDescription[];
+
+extern const char kEnableSyncPseudoUSSSearchEnginesName[];
+extern const char kEnableSyncPseudoUSSSearchEnginesDescription[];
+
+extern const char kEnableSyncPseudoUSSSupervisedUsersName[];
+extern const char kEnableSyncPseudoUSSSupervisedUsersDescription[];
+
+extern const char kEnableSyncPseudoUSSThemesName[];
+extern const char kEnableSyncPseudoUSSThemesDescription[];
+
 extern const char kEnableSyncUserConsentSeparateTypeName[];
 extern const char kEnableSyncUserConsentSeparateTypeDescription[];