cc: Pass scaled bounds to debug border quads for drawing.

As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623

Review URL: https://codereview.chromium.org/341023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278810 0039d316-1c4b-4281-b951-d872f2087c98
parent bc1cb4d8
...@@ -69,7 +69,8 @@ void IOSurfaceLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -69,7 +69,8 @@ void IOSurfaceLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
gfx::Rect quad_rect(content_bounds()); gfx::Rect quad_rect(content_bounds());
gfx::Rect opaque_rect(contents_opaque() ? quad_rect : gfx::Rect()); gfx::Rect opaque_rect(contents_opaque() ? quad_rect : gfx::Rect());
......
...@@ -289,16 +289,22 @@ void LayerImpl::GetDebugBorderProperties(SkColor* color, float* width) const { ...@@ -289,16 +289,22 @@ void LayerImpl::GetDebugBorderProperties(SkColor* color, float* width) const {
void LayerImpl::AppendDebugBorderQuad( void LayerImpl::AppendDebugBorderQuad(
QuadSink* quad_sink, QuadSink* quad_sink,
const gfx::Size& content_bounds,
const SharedQuadState* shared_quad_state, const SharedQuadState* shared_quad_state,
AppendQuadsData* append_quads_data) const { AppendQuadsData* append_quads_data) const {
SkColor color; SkColor color;
float width; float width;
GetDebugBorderProperties(&color, &width); GetDebugBorderProperties(&color, &width);
AppendDebugBorderQuad( AppendDebugBorderQuad(quad_sink,
quad_sink, shared_quad_state, append_quads_data, color, width); content_bounds,
shared_quad_state,
append_quads_data,
color,
width);
} }
void LayerImpl::AppendDebugBorderQuad(QuadSink* quad_sink, void LayerImpl::AppendDebugBorderQuad(QuadSink* quad_sink,
const gfx::Size& content_bounds,
const SharedQuadState* shared_quad_state, const SharedQuadState* shared_quad_state,
AppendQuadsData* append_quads_data, AppendQuadsData* append_quads_data,
SkColor color, SkColor color,
...@@ -306,7 +312,7 @@ void LayerImpl::AppendDebugBorderQuad(QuadSink* quad_sink, ...@@ -306,7 +312,7 @@ void LayerImpl::AppendDebugBorderQuad(QuadSink* quad_sink,
if (!ShowDebugBorders()) if (!ShowDebugBorders())
return; return;
gfx::Rect quad_rect(content_bounds()); gfx::Rect quad_rect(content_bounds);
gfx::Rect visible_quad_rect(quad_rect); gfx::Rect visible_quad_rect(quad_rect);
scoped_ptr<DebugBorderDrawQuad> debug_border_quad = scoped_ptr<DebugBorderDrawQuad> debug_border_quad =
DebugBorderDrawQuad::Create(); DebugBorderDrawQuad::Create();
......
...@@ -540,9 +540,11 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver, ...@@ -540,9 +540,11 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
virtual void GetDebugBorderProperties(SkColor* color, float* width) const; virtual void GetDebugBorderProperties(SkColor* color, float* width) const;
void AppendDebugBorderQuad(QuadSink* quad_sink, void AppendDebugBorderQuad(QuadSink* quad_sink,
const gfx::Size& content_bounds,
const SharedQuadState* shared_quad_state, const SharedQuadState* shared_quad_state,
AppendQuadsData* append_quads_data) const; AppendQuadsData* append_quads_data) const;
void AppendDebugBorderQuad(QuadSink* quad_sink, void AppendDebugBorderQuad(QuadSink* quad_sink,
const gfx::Size& content_bounds,
const SharedQuadState* shared_quad_state, const SharedQuadState* shared_quad_state,
AppendQuadsData* append_quads_data, AppendQuadsData* append_quads_data,
SkColor color, SkColor color,
......
...@@ -86,7 +86,8 @@ void NinePatchLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -86,7 +86,8 @@ void NinePatchLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
if (!ui_resource_id_) if (!ui_resource_id_)
return; return;
......
...@@ -81,7 +81,8 @@ void PaintedScrollbarLayerImpl::AppendQuads( ...@@ -81,7 +81,8 @@ void PaintedScrollbarLayerImpl::AppendQuads(
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
gfx::Rect thumb_quad_rect = ComputeThumbQuadRect(); gfx::Rect thumb_quad_rect = ComputeThumbQuadRect();
gfx::Rect visible_thumb_quad_rect = gfx::Rect visible_thumb_quad_rect =
......
...@@ -165,6 +165,7 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -165,6 +165,7 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink,
if (current_draw_mode_ == DRAW_MODE_RESOURCELESS_SOFTWARE) { if (current_draw_mode_ == DRAW_MODE_RESOURCELESS_SOFTWARE) {
AppendDebugBorderQuad( AppendDebugBorderQuad(
quad_sink, quad_sink,
scaled_content_bounds,
shared_quad_state, shared_quad_state,
append_quads_data, append_quads_data,
DebugColors::DirectPictureBorderColor(), DebugColors::DirectPictureBorderColor(),
...@@ -197,7 +198,8 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -197,7 +198,8 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink,
return; return;
} }
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, scaled_content_bounds, shared_quad_state, append_quads_data);
if (ShowDebugBorders()) { if (ShowDebugBorders()) {
for (PictureLayerTilingSet::CoverageIterator iter( for (PictureLayerTilingSet::CoverageIterator iter(
......
...@@ -27,7 +27,8 @@ void SolidColorLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -27,7 +27,8 @@ void SolidColorLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
// We create a series of smaller quads instead of just one large one so that // We create a series of smaller quads instead of just one large one so that
// the culler can reduce the total pixels drawn. // the culler can reduce the total pixels drawn.
......
...@@ -99,7 +99,8 @@ void SolidColorScrollbarLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -99,7 +99,8 @@ void SolidColorScrollbarLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
gfx::Rect thumb_quad_rect(ComputeThumbQuadRect()); gfx::Rect thumb_quad_rect(ComputeThumbQuadRect());
gfx::Rect visible_quad_rect = quad_sink->UnoccludedContentRect( gfx::Rect visible_quad_rect = quad_sink->UnoccludedContentRect(
......
...@@ -41,7 +41,8 @@ void SurfaceLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -41,7 +41,8 @@ void SurfaceLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
if (surface_id_.is_null()) if (surface_id_.is_null())
return; return;
......
...@@ -146,7 +146,8 @@ void TextureLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -146,7 +146,8 @@ void TextureLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
SkColor bg_color = blend_background_color_ ? SkColor bg_color = blend_background_color_ ?
background_color() : SK_ColorTRANSPARENT; background_color() : SK_ColorTRANSPARENT;
......
...@@ -161,7 +161,8 @@ void TiledLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -161,7 +161,8 @@ void TiledLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
int left, top, right, bottom; int left, top, right, bottom;
tiler_->ContentRectToTileIndices(content_rect, &left, &top, &right, &bottom); tiler_->ContentRectToTileIndices(content_rect, &left, &top, &right, &bottom);
......
...@@ -96,7 +96,8 @@ void UIResourceLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -96,7 +96,8 @@ void UIResourceLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
if (!ui_resource_id_) if (!ui_resource_id_)
return; return;
......
...@@ -131,7 +131,8 @@ void VideoLayerImpl::AppendQuads(QuadSink* quad_sink, ...@@ -131,7 +131,8 @@ void VideoLayerImpl::AppendQuads(QuadSink* quad_sink,
SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState(); SharedQuadState* shared_quad_state = quad_sink->CreateSharedQuadState();
PopulateSharedQuadState(shared_quad_state); PopulateSharedQuadState(shared_quad_state);
AppendDebugBorderQuad(quad_sink, shared_quad_state, append_quads_data); AppendDebugBorderQuad(
quad_sink, content_bounds(), shared_quad_state, append_quads_data);
gfx::Rect quad_rect(content_bounds()); gfx::Rect quad_rect(content_bounds());
gfx::Rect opaque_rect(contents_opaque() ? quad_rect : gfx::Rect()); gfx::Rect opaque_rect(contents_opaque() ? quad_rect : gfx::Rect());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment