Commit b4a2e385 authored by Armando Miraglia's avatar Armando Miraglia Committed by Commit Bot

[Video Capture] Make feature available as flag for windows.

To make sure that certain users are able to programmatically configure
how the video capture service is run, this CL makes a flag available to
direct whether the video should run in the browser process or separately.

Fixed: 1047682
Change-Id: If871f13c320a39abcd558b371e7b7132f0316767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082390
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746769}
parent 22d6d1cc
...@@ -4881,6 +4881,14 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -4881,6 +4881,14 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_VALUE_TYPE(features::kUserDataSnapshot)}, FEATURE_VALUE_TYPE(features::kUserDataSnapshot)},
#endif #endif
#if defined(OS_WIN)
{"run-video-capture-service-in-browser",
flag_descriptions::kRunVideoCaptureServiceInBrowserProcessName,
flag_descriptions::kRunVideoCaptureServiceInBrowserProcessDescription,
kOsWin,
FEATURE_VALUE_TYPE(features::kRunVideoCaptureServiceInBrowserProcess)},
#endif // defined(OS_WIN)
{"legacy-tls-enforced", flag_descriptions::kLegacyTLSEnforcedName, {"legacy-tls-enforced", flag_descriptions::kLegacyTLSEnforcedName,
flag_descriptions::kLegacyTLSEnforcedDescription, kOsDesktop | kOsAndroid, flag_descriptions::kLegacyTLSEnforcedDescription, kOsDesktop | kOsAndroid,
FEATURE_VALUE_TYPE(net::features::kLegacyTLSEnforced)}, FEATURE_VALUE_TYPE(net::features::kLegacyTLSEnforced)},
......
...@@ -3144,6 +3144,11 @@ ...@@ -3144,6 +3144,11 @@
"owners": [ "dullweber" ], "owners": [ "dullweber" ],
"expiry_milestone": 75 "expiry_milestone": 75
}, },
{
"name": "run-video-capture-service-in-browser",
"owners": [ "armax", "guidou" ],
"expiry_milestone": 90
},
{ {
"name": "safety-tips", "name": "safety-tips",
"owners": [ "jdeblasio", "estark", "meacer" ], "owners": [ "jdeblasio", "estark", "meacer" ],
......
...@@ -3759,6 +3759,15 @@ const char kUserDataSnapshotDescription[] = ...@@ -3759,6 +3759,15 @@ const char kUserDataSnapshotDescription[] =
#endif // !defined(OS_ANDROID) && !defined(OS_CHROMEOS) #endif // !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
#if defined(OS_WIN)
const char kRunVideoCaptureServiceInBrowserProcessName[] =
"Run video capture service in browser";
const char kRunVideoCaptureServiceInBrowserProcessDescription[] =
"Run the video capture service in the browser process.";
#endif // defined(OS_WIN)
// ============================================================================ // ============================================================================
// Don't just add flags to the end, put them in the right section in // Don't just add flags to the end, put them in the right section in
// alphabetical order just like the header file. // alphabetical order just like the header file.
......
...@@ -2218,6 +2218,13 @@ extern const char kUserDataSnapshotDescription[]; ...@@ -2218,6 +2218,13 @@ extern const char kUserDataSnapshotDescription[];
#endif // !defined(OS_ANDROID) && !defined(OS_CHROMEOS) #endif // !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
#if defined(OS_WIN)
extern const char kRunVideoCaptureServiceInBrowserProcessName[];
extern const char kRunVideoCaptureServiceInBrowserProcessDescription[];
#endif // defined(OS_WIN)
// ============================================================================ // ============================================================================
// Don't just add flags to the end, put them in the right section in // Don't just add flags to the end, put them in the right section in
// alphabetical order. See top instructions for more. // alphabetical order. See top instructions for more.
......
...@@ -37434,6 +37434,8 @@ from previous Chrome versions. ...@@ -37434,6 +37434,8 @@ from previous Chrome versions.
<int value="-1776351704" label="DesktopPWAsOmniboxInstall:disabled"/> <int value="-1776351704" label="DesktopPWAsOmniboxInstall:disabled"/>
<int value="-1774818943" label="VrWebInputEditing:enabled"/> <int value="-1774818943" label="VrWebInputEditing:enabled"/>
<int value="-1772942854" label="LongPressBackForHistory:enabled"/> <int value="-1772942854" label="LongPressBackForHistory:enabled"/>
<int value="-1772905637"
label="RunVideoCaptureServiceInBrowserProcess:enabled"/>
<int value="-1772172557" label="enable-osk-overscroll"/> <int value="-1772172557" label="enable-osk-overscroll"/>
<int value="-1768672408" label="ChromeDuplex:disabled"/> <int value="-1768672408" label="ChromeDuplex:disabled"/>
<int value="-1768308156" label="OmniboxDedupeGoogleDriveURLs:enabled"/> <int value="-1768308156" label="OmniboxDedupeGoogleDriveURLs:enabled"/>
...@@ -38897,6 +38899,8 @@ from previous Chrome versions. ...@@ -38897,6 +38899,8 @@ from previous Chrome versions.
<int value="-20438829" label="SyncUSSAutofillProfile:enabled"/> <int value="-20438829" label="SyncUSSAutofillProfile:enabled"/>
<int value="-20329017" label="EduCoexistence:disabled"/> <int value="-20329017" label="EduCoexistence:disabled"/>
<int value="-20267582" label="ResourceLoadingHints:disabled"/> <int value="-20267582" label="ResourceLoadingHints:disabled"/>
<int value="-19498390"
label="RunVideoCaptureServiceInBrowserProcess:disabled"/>
<int value="-18464041" label="AutofillPrefilledFields:disabled"/> <int value="-18464041" label="AutofillPrefilledFields:disabled"/>
<int value="-17698200" label="DoubleTapToZoomInTabletMode:disabled"/> <int value="-17698200" label="DoubleTapToZoomInTabletMode:disabled"/>
<int value="-17373827" label="SharingDeviceExpiration:enabled"/> <int value="-17373827" label="SharingDeviceExpiration:enabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment