Commit b4ac7129 authored by Owen Min's avatar Owen Min Committed by Commit Bot

CleansUpContextJobs disable does not need OS condition

ContextProviderImplTest.CleansUpContextJobs is only ran on Fuchsia, hence
there is no need to add the condition.

Bug: 989085
Change-Id: Iee8fe325681b3a38374ab52a1ff29f794a2569f6
TBR: wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729471Reviewed-by: default avatarOwen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682807}
parent 1bdd7918
......@@ -33,7 +33,6 @@
#include "base/path_service.h"
#include "base/test/multiprocess_test.h"
#include "base/test/test_timeouts.h"
#include "build/build_config.h"
#include "fuchsia/engine/common.h"
#include "fuchsia/engine/fake_context.h"
#include "testing/gtest/include/gtest/gtest.h"
......@@ -325,12 +324,7 @@ static bool WaitUntilJobIsEmpty(zx::unowned_job job, zx::duration timeout) {
// Regression test for https://crbug.com/927403 (Job leak per-Context).
// TODO(http://crbug.com/989085): Flakily fails on Fuchsia x64.
#if defined(OS_FUCHSIA)
#define MAYBE_CleansUpContextJobs DISABLED_CleansUpContextJobs
#else
#define MAYBE_CleansUpContextJobs CleansUpContextJobs
#endif
TEST_F(ContextProviderImplTest, MAYBE_CleansUpContextJobs) {
TEST_F(ContextProviderImplTest, DISABLED_CleansUpContextJobs) {
// Replace the default job with one that is guaranteed to be empty.
zx::job job;
ASSERT_EQ(base::GetDefaultJob()->duplicate(ZX_RIGHT_SAME_RIGHTS, &job),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment