Move token vector on CSSVariableData construction

There seems to be no reason to copy it.

Change-Id: I89779533927d3b3d2a3ca912226eba723d9bc5c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306149
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790353}

third_party/blink/renderer/core/css/css_variable_data.h

@@ -38,7 +38,7 @@ class CORE_EXPORT CSSVariableData : public RefCounted<CSSVariableData> {
   }
 
   static scoped_refptr<CSSVariableData> CreateResolved(
-      const Vector<CSSParserToken>& resolved_tokens,
+      Vector<CSSParserToken> resolved_tokens,
       Vector<String> backing_strings,
       bool is_animation_tainted,
       bool has_font_units,
@@ -46,8 +46,9 @@ class CORE_EXPORT CSSVariableData : public RefCounted<CSSVariableData> {
       const String& base_url,
       const WTF::TextEncoding& charset) {
     return base::AdoptRef(new CSSVariableData(
-        resolved_tokens, std::move(backing_strings), is_animation_tainted,
-        has_font_units, has_root_font_units, base_url, charset));
+        std::move(resolved_tokens), std::move(backing_strings),
+        is_animation_tainted, has_font_units, has_root_font_units, base_url,
+        charset));
   }
 
   CSSParserTokenRange TokenRange() const { return tokens_; }
@@ -89,7 +90,7 @@ class CORE_EXPORT CSSVariableData : public RefCounted<CSSVariableData> {
                   const KURL& base_url,
                   const WTF::TextEncoding& charset);
 
-  CSSVariableData(const Vector<CSSParserToken>& resolved_tokens,
+  CSSVariableData(Vector<CSSParserToken> resolved_tokens,
                   Vector<String> backing_strings,
                   bool is_animation_tainted,
                   bool has_font_units,
@@ -97,7 +98,7 @@ class CORE_EXPORT CSSVariableData : public RefCounted<CSSVariableData> {
                   const String& base_url,
                   const WTF::TextEncoding& charset)
       : backing_strings_(std::move(backing_strings)),
-        tokens_(resolved_tokens),
+        tokens_(std::move(resolved_tokens)),
         is_animation_tainted_(is_animation_tainted),
         needs_variable_resolution_(false),
         has_font_units_(has_font_units),

third_party/blink/renderer/core/css/resolver/style_builder_converter.cc

@@ -1976,8 +1976,8 @@ StyleBuilderConverter::ConvertRegisteredPropertyVariableData(
   const bool has_root_font_units = false;
 
   return CSSVariableData::CreateResolved(
-      tokens, std::move(backing_strings), is_animation_tainted, has_font_units,
-      has_root_font_units, g_null_atom, WTF::TextEncoding());
+      std::move(tokens), std::move(backing_strings), is_animation_tainted,
+      has_font_units, has_root_font_units, g_null_atom, WTF::TextEncoding());
 }
 
 LengthSize StyleBuilderConverter::ConvertIntrinsicSize(

third_party/blink/renderer/core/css/resolver/style_cascade.cc

@@ -530,9 +530,8 @@ void StyleCascade::TokenSequence::Append(const CSSParserToken& token) {
 
 scoped_refptr<CSSVariableData>
 StyleCascade::TokenSequence::BuildVariableData() {
-  // TODO(andruud): Why not also std::move tokens?
   return CSSVariableData::CreateResolved(
-      tokens_, std::move(backing_strings_), is_animation_tainted_,
+      std::move(tokens_), std::move(backing_strings_), is_animation_tainted_,
       has_font_units_, has_root_font_units_, base_url_, charset_);
 }
 

third_party/blink/renderer/core/css/style_environment_variables.cc

@@ -149,11 +149,12 @@ void StyleEnvironmentVariables::SetVariable(const AtomicString& name,
   Vector<String> backing_strings;
   backing_strings.push_back(value);
 
-  SetVariable(name,
-              CSSVariableData::CreateResolved(
-                  tokens, backing_strings, false /* is_animation_tainted */,
-                  false /* has_font_units */, false /* has_root_font_units*/,
-                  g_null_atom, WTF::TextEncoding()));
+  SetVariable(
+      name,
+      CSSVariableData::CreateResolved(
+          std::move(tokens), std::move(backing_strings),
+          false /* is_animation_tainted */, false /* has_font_units */,
+          false /* has_root_font_units*/, g_null_atom, WTF::TextEncoding()));
 }
 
 void StyleEnvironmentVariables::SetVariable(const UADefinedVariable name,