Commit b4dfd1db authored by Christoph Schwering's avatar Christoph Schwering Committed by Commit Bot

[Autofill] Removed obsolete feature AutofillPreferServerNamePredictions.

The feature is disabled by default and is not subject to an active
experiment.

Bug: 1007974
Change-Id: I304f6a1c64ff3370fff91c63bb50ce1441d9bf1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410020
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: default avatarMatthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#809611}
parent fae9ed0b
...@@ -129,20 +129,14 @@ AutofillType AutofillField::ComputedType() const { ...@@ -129,20 +129,14 @@ AutofillType AutofillField::ComputedType() const {
// decision to prefer the heuristics in these cases, but it looks like // decision to prefer the heuristics in these cases, but it looks like
// it might be better to fix this server-side. // it might be better to fix this server-side.
// See http://crbug.com/429236 for background. // See http://crbug.com/429236 for background.
bool believe_server; bool believe_server = !(server_type_ == NAME_FULL &&
if (base::FeatureList::IsEnabled( heuristic_type_ == CREDIT_CARD_NAME_FULL) &&
features::kAutofillPreferServerNamePredictions)) { !(server_type_ == CREDIT_CARD_NAME_FULL &&
believe_server = true; heuristic_type_ == NAME_FULL) &&
} else { !(server_type_ == NAME_FIRST &&
believe_server = !(server_type_ == NAME_FULL && heuristic_type_ == CREDIT_CARD_NAME_FIRST) &&
heuristic_type_ == CREDIT_CARD_NAME_FULL) && !(server_type_ == NAME_LAST &&
!(server_type_ == CREDIT_CARD_NAME_FULL && heuristic_type_ == CREDIT_CARD_NAME_LAST);
heuristic_type_ == NAME_FULL) &&
!(server_type_ == NAME_FIRST &&
heuristic_type_ == CREDIT_CARD_NAME_FIRST) &&
!(server_type_ == NAME_LAST &&
heuristic_type_ == CREDIT_CARD_NAME_LAST);
}
// Either way, retain a preference for the the CVC heuristic over the // Either way, retain a preference for the the CVC heuristic over the
// server's password predictions (http://crbug.com/469007) // server's password predictions (http://crbug.com/469007)
......
...@@ -191,9 +191,6 @@ const base::Feature kAutofillOffNoServerData{"AutofillOffNoServerData", ...@@ -191,9 +191,6 @@ const base::Feature kAutofillOffNoServerData{"AutofillOffNoServerData",
const base::Feature kAutofillOverrideWithRaterConsensus{ const base::Feature kAutofillOverrideWithRaterConsensus{
"AutofillOverrideWithRaterConsensus", base::FEATURE_DISABLED_BY_DEFAULT}; "AutofillOverrideWithRaterConsensus", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kAutofillPreferServerNamePredictions{
"AutofillPreferServerNamePredictions", base::FEATURE_DISABLED_BY_DEFAULT};
// If feature is enabled, autofill will be disabled for mixed forms (forms on // If feature is enabled, autofill will be disabled for mixed forms (forms on
// HTTPS sites that submit over HTTP). // HTTPS sites that submit over HTTP).
const base::Feature kAutofillPreventMixedFormsFilling{ const base::Feature kAutofillPreventMixedFormsFilling{
......
...@@ -54,7 +54,6 @@ extern const base::Feature kAutofillPruneSuggestions; ...@@ -54,7 +54,6 @@ extern const base::Feature kAutofillPruneSuggestions;
extern const base::Feature kAutofillMetadataUploads; extern const base::Feature kAutofillMetadataUploads;
extern const base::Feature kAutofillOffNoServerData; extern const base::Feature kAutofillOffNoServerData;
extern const base::Feature kAutofillOverrideWithRaterConsensus; extern const base::Feature kAutofillOverrideWithRaterConsensus;
extern const base::Feature kAutofillPreferServerNamePredictions;
extern const base::Feature kAutofillPreventMixedFormsFilling; extern const base::Feature kAutofillPreventMixedFormsFilling;
extern const base::Feature kAutofillProbableFormSubmissionInBrowser; extern const base::Feature kAutofillProbableFormSubmissionInBrowser;
extern const base::Feature kAutofillProfileClientValidation; extern const base::Feature kAutofillProfileClientValidation;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment